From 3ffbde6fa1c63df6ff55ab5f4fb3151bd881e539 Mon Sep 17 00:00:00 2001 From: alemate Date: Mon, 2 Nov 2015 18:02:55 -0800 Subject: This CL replaces user_manager::UserID with AccountId. This CL replaces API of user_manager::UserManager, thus modifying API of all child objects, and all calls to UserManager. This is part of transition to AccountId. BUG=468875 TEST=manual Committed: https://crrev.com/cd06408625de9e0d5cf4c7c1ede412cb5c82542b Cr-Commit-Position: refs/heads/master@{#357119} Review URL: https://codereview.chromium.org/1412813003 Cr-Commit-Position: refs/heads/master@{#357512} --- ash/test/test_session_state_delegate.cc | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) (limited to 'ash/test') diff --git a/ash/test/test_session_state_delegate.cc b/ash/test/test_session_state_delegate.cc index 7f2e648..bd0bdd3 100644 --- a/ash/test/test_session_state_delegate.cc +++ b/ash/test/test_session_state_delegate.cc @@ -12,6 +12,7 @@ #include "base/stl_util.h" #include "base/strings/string16.h" #include "base/strings/utf_string_conversions.h" +#include "components/signin/core/account_id/account_id.h" #include "components/user_manager/user_info.h" #include "testing/gtest/include/gtest/gtest.h" @@ -20,18 +21,20 @@ namespace test { namespace { -// The the "canonicalized" user ID from a given |email| address. -std::string GetUserIDFromEmail(const std::string& email) { +// The the "canonicalized" Account ID from a given |email| address. +AccountId GetAccountIdFromEmail(const std::string& email) { std::string user_id = email; std::transform(user_id.begin(), user_id.end(), user_id.begin(), ::tolower); - return user_id; + return AccountId::FromUserEmail(user_id); } } // namespace class MockUserInfo : public user_manager::UserInfo { public: - explicit MockUserInfo(const std::string& id) : email_(id) {} + explicit MockUserInfo(const std::string& display_email) + : display_email_(display_email), + account_id_(GetAccountIdFromEmail(display_email)) {} ~MockUserInfo() override {} void SetUserImage(const gfx::ImageSkia& user_image) { @@ -46,18 +49,17 @@ class MockUserInfo : public user_manager::UserInfo { return base::UTF8ToUTF16("Über Über Über Über"); } - std::string GetEmail() const override { return email_; } + std::string GetEmail() const override { return display_email_; } - std::string GetUserID() const override { - return GetUserIDFromEmail(GetEmail()); - } + AccountId GetAccountId() const override { return account_id_; } const gfx::ImageSkia& GetImage() const override { return user_image_; } // A test user image. gfx::ImageSkia user_image_; - std::string email_; + std::string display_email_; + const AccountId account_id_; DISALLOW_COPY_AND_ASSIGN(MockUserInfo); }; @@ -215,18 +217,19 @@ gfx::ImageSkia TestSessionStateDelegate::GetAvatarImageForWindow( } void TestSessionStateDelegate::SwitchActiveUser(const std::string& user_id) { + const AccountId account_id(GetAccountIdFromEmail(user_id)); // Make sure this is a user id and not an email address. - EXPECT_EQ(user_id, GetUserIDFromEmail(user_id)); + EXPECT_EQ(user_id, account_id.GetUserEmail()); active_user_index_ = 0; for (std::vector::iterator iter = user_list_.begin(); iter != user_list_.end(); ++iter) { - if ((*iter)->GetUserID() == user_id) { + if ((*iter)->GetAccountId() == account_id) { active_user_index_ = iter - user_list_.begin(); return; } } - NOTREACHED() << "Unknown user:" << user_id; + NOTREACHED() << "Unknown user:" << account_id.GetUserEmail(); } void TestSessionStateDelegate::CycleActiveUser(CycleUser cycle_user) { -- cgit v1.1