From 307175443726a8a2a23b99371900812bb020f9a0 Mon Sep 17 00:00:00 2001 From: "erg@google.com" Date: Wed, 28 Jul 2010 00:09:54 +0000 Subject: Speculative fix for crash in DOMUIThumbnailSource. DOMUIThumbnailSource objects are deleted on the IO thread, while they are used on the UI thread. The DataSource documentation says that they should not live on the IO thread, but for almost all DataSources, the only reference held is the one by ChromeURLDataManager, which lives on the IO thread. Since I had a racy stack where the object was being used on the UI thread while its destructor was running on the IO thread, forcing destruction on the UI thread should fix the crash. Pretty much everything but changing the templated base class of DataSource to always DeleteOnUIThread is my usual cleanup. BUG=34115 TEST=none Review URL: http://codereview.chromium.org/3061009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53873 0039d316-1c4b-4281-b951-d872f2087c98 --- base/base.gypi | 1 + 1 file changed, 1 insertion(+) (limited to 'base/base.gypi') diff --git a/base/base.gypi b/base/base.gypi index 2553ab5..cad0256 100644 --- a/base/base.gypi +++ b/base/base.gypi @@ -176,6 +176,7 @@ 'raw_scoped_refptr_mismatch_checker.h', 'ref_counted.cc', 'ref_counted.h', + 'ref_counted_memory.cc', 'ref_counted_memory.h', 'registry.cc', 'registry.h', -- cgit v1.1