From 1a150551a669a94dbdc316b452721b721354bedc Mon Sep 17 00:00:00 2001 From: "wangxianzhu@chromium.org" Date: Mon, 10 Mar 2014 18:23:38 +0000 Subject: Let DCHECK in non-official-release build be opt-in with dcheck_always_on=1 only - Remove DCHECK in non-official-release build by default - Gyp variable dcheck_always_on=1 (existing) forces to enable DCHECK in release build - Remove flag --enable-dcheck Other effects/notes: - Now allow "buildtype=Official dcheck_always_on=1" (which will enable DCHECK in official build) combination. - Gyp variable logging_like_official_build no longer has an effect - Leave DCHECK_IS_ON() unchanged. May deal with it in a later change if needed. This won't affect bots which use dcheck_always_on=1. BUG=350462 TEST=LoggingTest.Dcheck R=thakis@chromium.org TBR=darin,sehr (command line changes in components/nacl and mojo) Review URL: https://codereview.chromium.org/189603007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255987 0039d316-1c4b-4281-b951-d872f2087c98 --- base/base_switches.h | 1 - 1 file changed, 1 deletion(-) (limited to 'base/base_switches.h') diff --git a/base/base_switches.h b/base/base_switches.h index b679e6d..70d02e2 100644 --- a/base/base_switches.h +++ b/base/base_switches.h @@ -14,7 +14,6 @@ namespace switches { extern const char kDebugOnStart[]; extern const char kDisableBreakpad[]; extern const char kEnableCrashReporter[]; -extern const char kEnableDCHECK[]; extern const char kFullMemoryCrashReport[]; extern const char kNoErrorDialogs[]; extern const char kProfilerTiming[]; -- cgit v1.1