From 3a3d4747769aec2954a2ca21de4812c5892994aa Mon Sep 17 00:00:00 2001 From: "erg@chromium.org" Date: Thu, 15 Jul 2010 21:03:54 +0000 Subject: Move implementation from header to source. This is an effort to speed up compile and link time, and also minimizing the size of the intermediary .o files on disk. For example, just moving the constructor/destructor from the classes in chrome/browser/pref_member.{cc,h} netted a 368k drop in total .o file size. In aggregate, this shrinks libbrowser.a by 10 megabytes, and a few odd megabytes on most other chrome .a files. A lot of this was done before I started harvesting what the most included symbols were across all of chrome's code. Most of them are in webkit, but there's plenty in base/ that are used everywhere to keep me busy for several patches to come. BUG=none TEST=none Review URL: http://codereview.chromium.org/3012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52528 0039d316-1c4b-4281-b951-d872f2087c98 --- base/env_var.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'base/env_var.h') diff --git a/base/env_var.h b/base/env_var.h index 6888353..3cc2399 100644 --- a/base/env_var.h +++ b/base/env_var.h @@ -14,15 +14,14 @@ namespace base { // These are used to derive mocks for unittests. class EnvVarGetter { public: - virtual ~EnvVarGetter() {} + virtual ~EnvVarGetter(); + // Gets an environment variable's value and stores it in |result|. // Returns false if the key is unset. virtual bool GetEnv(const char* variable_name, std::string* result) = 0; // Syntactic sugar for GetEnv(variable_name, NULL); - virtual bool HasEnv(const char* variable_name) { - return GetEnv(variable_name, NULL); - } + virtual bool HasEnv(const char* variable_name); virtual void SetEnv(const char* variable_name, const std::string& new_value) = 0; -- cgit v1.1