From 48c70517e3bb914c4157e27fb0d70492f4f76cbe Mon Sep 17 00:00:00 2001 From: "xji@chromium.org" Date: Wed, 16 Sep 2009 17:21:13 +0000 Subject: =?UTF-8?q?=C3=AF=C2=BB=C2=BFThis=20CL=20fixes=20issue=2010860=20-?= =?UTF-8?q?=20RTL:=20Hebrew=20file=20names=20should=20have=20forced=20LTR?= =?UTF-8?q?=20directionality=20in=20download=20shelf.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit File names in download shelf are forced to be LTR in DownloadItemView and through ElideFileName(). BUG=http://crbug.com/10860 TEST=1. Open chrome with Hebrew UI. 2. Right click a link and chose Save As... (4th item from the top for non-Hebrew speakers) 3. In the save as dialog name the file קובץ.html 4. In the download shelf the filename should display as קובץ.html (not html.קובץ) Review URL: http://codereview.chromium.org/131001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26359 0039d316-1c4b-4281-b951-d872f2087c98 --- base/file_path.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'base/file_path.h') diff --git a/base/file_path.h b/base/file_path.h index b608651..e1dbd22 100644 --- a/base/file_path.h +++ b/base/file_path.h @@ -61,7 +61,13 @@ // | FilePath log_file_path(kLogFileName); // | [...] // | } - +// +// WARNING: FilePaths should ALWAYS be displayed with LTR directionality, even +// when the UI language is RTL. This means you always need to pass filepaths +// through l10n_util::WrapPathWithLTRFormatting() before displaying it in the +// RTL UI. +// +// This is a very common source of bugs, please try to keep this in mind. #ifndef BASE_FILE_PATH_H_ #define BASE_FILE_PATH_H_ -- cgit v1.1