From 1180a85e0e75826b2156caf2049d5663be6956fd Mon Sep 17 00:00:00 2001 From: "jrg@chromium.org" Date: Thu, 16 Apr 2009 21:29:58 +0000 Subject: Minor tweaks to deal with the split between CFBundleVersion (which has numerical limits) and Chrome version (which does not). Use Chrome version when we can. Review URL: http://codereview.chromium.org/79021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13881 0039d316-1c4b-4281-b951-d872f2087c98 --- base/file_version_info_mac.mm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'base/file_version_info_mac.mm') diff --git a/base/file_version_info_mac.mm b/base/file_version_info_mac.mm index 3813cc6..00f470b 100644 --- a/base/file_version_info_mac.mm +++ b/base/file_version_info_mac.mm @@ -86,7 +86,12 @@ std::wstring FileVersionInfo::private_build() { } std::wstring FileVersionInfo::file_version() { - return GetStringValue(L"CFBundleVersion"); + // CFBundleVersion has limitations that may not be honored by a + // proper Chromium version number, so try KSVersion first. + std::wstring version = GetStringValue(L"KSVersion"); + if (version == L"") + version = GetStringValue(L"CFBundleVersion"); + return version; } std::wstring FileVersionInfo::original_filename() { -- cgit v1.1