From 0ef8a9950e414678454e65bdf6581e7d16dec03f Mon Sep 17 00:00:00 2001 From: "eroman@chromium.org" Date: Mon, 21 Sep 2009 19:44:54 +0000 Subject: Copy the leak callstacks onto the stack before crashing in LeakTracker::CheckForLeaks. This way if it is enabled in release builds, the mini-dump will contain the allocation stacktrace. Review URL: http://codereview.chromium.org/208001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26717 0039d316-1c4b-4281-b951-d872f2087c98 --- base/leak_tracker.h | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) (limited to 'base/leak_tracker.h') diff --git a/base/leak_tracker.h b/base/leak_tracker.h index a5d105a..de6ff29 100644 --- a/base/leak_tracker.h +++ b/base/leak_tracker.h @@ -72,15 +72,35 @@ class LeakTracker : public LinkNode > { static void CheckForLeaks() { // Walk the allocation list and print each entry it contains. - int count = 0; + size_t count = 0; + + // Copy the first 3 leak allocation callstacks onto the stack. + // This way if we hit the CHECK() in a release build, the leak + // information will be available in mini-dump. + const size_t kMaxStackTracesToCopyOntoStack = 3; + StackTrace stacktraces[kMaxStackTracesToCopyOntoStack]; + for (LinkNode >* node = instances()->head(); node != instances()->end(); node = node->next()) { + StackTrace& allocation_stack = node->value()->allocation_stack_; + + if (count < kMaxStackTracesToCopyOntoStack) + stacktraces[count] = allocation_stack; + ++count; LOG(ERROR) << "Leaked " << node << " which was allocated by:"; - node->value()->allocation_stack_.PrintBacktrace(); + allocation_stack.PrintBacktrace(); + } + + CHECK(0u == count); + + // Hack to keep |stacktraces| and |count| alive (so compiler + // doesn't optimize it out, and it will appear in mini-dumps). + if (count == 0x1234) { + for (size_t i = 0; i < kMaxStackTracesToCopyOntoStack; ++i) + stacktraces[i].PrintBacktrace(); } - CHECK(0 == count); } static int NumLiveInstances() { -- cgit v1.1