From 2b54eeb8250a162d30e65583b4d5b3783a4023c7 Mon Sep 17 00:00:00 2001 From: "mark@chromium.org" Date: Mon, 19 Oct 2009 20:05:50 +0000 Subject: Provide better diagnostics when launching with a silly executable path. BUG=24842 TEST=none Review URL: http://codereview.chromium.org/304004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29442 0039d316-1c4b-4281-b951-d872f2087c98 --- base/mac_util.mm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'base/mac_util.mm') diff --git a/base/mac_util.mm b/base/mac_util.mm index f31ca42..772fe16b 100644 --- a/base/mac_util.mm +++ b/base/mac_util.mm @@ -77,7 +77,7 @@ void SetOverrideAppBundle(NSBundle* bundle) { void SetOverrideAppBundlePath(const FilePath& file_path) { NSString* path = base::SysUTF8ToNSString(file_path.value()); NSBundle* bundle = [NSBundle bundleWithPath:path]; - DCHECK(bundle) << "failed to load the bundle: " << file_path.value(); + CHECK(bundle) << "Failed to load the bundle at " << file_path.value(); SetOverrideAppBundle(bundle); } @@ -146,7 +146,8 @@ static int g_full_screen_requests = 0; // Add a request for full screen mode. If the menu bar is not currently // hidden, hide it. Must be called on main thread. void RequestFullScreen() { - if (!g_full_screen_requests) + DCHECK_GE(g_full_screen_requests, 0); + if (g_full_screen_requests == 0) SetSystemUIMode(kUIModeAllSuppressed, kUIOptionAutoShowMenuBar); ++g_full_screen_requests; } @@ -154,7 +155,7 @@ void RequestFullScreen() { // Release a request for full screen mode. If there are no other outstanding // requests, show the menu bar. Must be called on main thread. void ReleaseFullScreen() { - DCHECK(g_full_screen_requests > 0); + DCHECK_GT(g_full_screen_requests, 0); --g_full_screen_requests; if (g_full_screen_requests == 0) SetSystemUIMode(kUIModeNormal, 0); -- cgit v1.1