From 84aebedeaa91c3fadf523260c12afa136420c7d3 Mon Sep 17 00:00:00 2001 From: "willchan@chromium.org" Date: Thu, 25 Feb 2010 03:09:41 +0000 Subject: Reland 39942 - Switch NetworkChangeNotifier implementations to use ObserverList. Fixed build problem with database_tracker.(cc|h). BUG=36590 Review URL: http://codereview.chromium.org/660039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39983 0039d316-1c4b-4281-b951-d872f2087c98 --- base/observer_list_unittest.cc | 49 ++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 47 insertions(+), 2 deletions(-) (limited to 'base/observer_list_unittest.cc') diff --git a/base/observer_list_unittest.cc b/base/observer_list_unittest.cc index 79af96a..6982d3d 100644 --- a/base/observer_list_unittest.cc +++ b/base/observer_list_unittest.cc @@ -172,8 +172,6 @@ class AddRemoveThread : public PlatformThread::Delegate, ScopedRunnableMethodFactory* factory_; }; -} // namespace - TEST(ObserverListTest, BasicTest) { ObserverList observer_list; Adder a(1), b(-1), c(1), d(-1); @@ -304,3 +302,50 @@ TEST(ObserverListTest, Existing) { FOR_EACH_OBSERVER(Foo, observer_list, Observe(1)); EXPECT_EQ(1, b.adder.total); } + +class AddInClearObserve : public Foo { + public: + explicit AddInClearObserve(ObserverList* list) + : list_(list), added_(false), adder_(1) {} + + virtual void Observe(int /* x */) { + list_->Clear(); + list_->AddObserver(&adder_); + added_ = true; + } + + bool added() const { return added_; } + const Adder& adder() const { return adder_; } + + private: + ObserverList* const list_; + + bool added_; + Adder adder_; +}; + +TEST(ObserverListTest, ClearNotifyAll) { + ObserverList observer_list; + AddInClearObserve a(&observer_list); + + observer_list.AddObserver(&a); + + FOR_EACH_OBSERVER(Foo, observer_list, Observe(1)); + EXPECT_TRUE(a.added()); + EXPECT_EQ(1, a.adder().total) + << "Adder should observe once and have sum of 1."; +} + +TEST(ObserverListTest, ClearNotifyExistingOnly) { + ObserverList observer_list(ObserverList::NOTIFY_EXISTING_ONLY); + AddInClearObserve a(&observer_list); + + observer_list.AddObserver(&a); + + FOR_EACH_OBSERVER(Foo, observer_list, Observe(1)); + EXPECT_TRUE(a.added()); + EXPECT_EQ(0, a.adder().total) + << "Adder should not observe, so sum should still be 0."; +} + +} // namespace -- cgit v1.1