From 51a4c029715cf5bd6bd7659186ce7a368fbb40a7 Mon Sep 17 00:00:00 2001 From: "vandebo@chromium.org" Date: Fri, 19 Mar 2010 22:01:59 +0000 Subject: Revert 42152 - Fix the case where the browser livelocks if we cannot open a file. If one tries to upload a file that one doesn't have read access to, the browser livelocks. It tries to read from the file, gets nothing but spins forever because it knows that it hasn't finished reading. To address this, firstly we add a check at stat() time to make sure that we can read the file. However, this doesn't take care of the case where the access() call was incorrect, or the permissions have changed under us. In this case, we replace the missing file with NULs. BUG=30850 Review URL: http://codereview.chromium.org/541022 TBR=vandebo@chromium.org Review URL: http://codereview.chromium.org/1145004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42154 0039d316-1c4b-4281-b951-d872f2087c98 --- base/platform_file_win.cc | 8 -------- 1 file changed, 8 deletions(-) (limited to 'base/platform_file_win.cc') diff --git a/base/platform_file_win.cc b/base/platform_file_win.cc index ccaee1e..1143487 100644 --- a/base/platform_file_win.cc +++ b/base/platform_file_win.cc @@ -75,12 +75,4 @@ bool ClosePlatformFile(PlatformFile file) { return (CloseHandle(file) == 0); } -bool GetPlatformFileSize(PlatformFile file, uint64* out_size) { - LARGE_INTEGER size; - if (!GetFileSizeEx(file, &size)) - return false; - *out_size = size.QuadPart; - return true; -} - } // namespace disk_cache -- cgit v1.1