From 0049398c72b3fd711c825d477e0db6943f8f5db6 Mon Sep 17 00:00:00 2001 From: "agl@chromium.org" Date: Fri, 23 Jan 2009 00:25:29 +0000 Subject: Use PlatformThreadId, not int when dealing with thread ids. Windows uses a DWORD (unsigned long) for thread ids and POSIX uses a pid_t (int on Linux) for the same. In the code, we are currently stuffing thread ids into an int which is dangerous on Windows (because DWORDS can exceed an int and wrap) and will break if pid_t is ever != int. This change changes all the places where we currently have an int to use a new typedef, PlatformThreadId. This change also needs to occur for process ids, but I'm not doing that in this CL. Review URL: http://codereview.chromium.org/18677 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8525 0039d316-1c4b-4281-b951-d872f2087c98 --- base/thread_collision_warner.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'base/thread_collision_warner.h') diff --git a/base/thread_collision_warner.h b/base/thread_collision_warner.h index fa8b7ee..6545451 100644 --- a/base/thread_collision_warner.h +++ b/base/thread_collision_warner.h @@ -225,7 +225,7 @@ class ThreadCollisionWarner { // This stores the thread id that is inside the critical section, if the // value is 0 then no thread is inside. - volatile int valid_thread_id_; + volatile subtle::Atomic32 valid_thread_id_; // Counter to trace how many time a critical section was "pinned" // (when allowed) in order to unpin it when counter_ reaches 0. -- cgit v1.1