From 68c7630b3ae6738e5b9ebb1998b3184fa930463c Mon Sep 17 00:00:00 2001 From: "simon.hong81@gmail.com" Date: Wed, 2 May 2012 22:37:42 +0000 Subject: Move RefCountedMemory Class to Base namespace BUG=none TEST=compiles chrome, browser_tests and ui_tests Review URL: http://codereview.chromium.org/10272004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135011 0039d316-1c4b-4281-b951-d872f2087c98 --- base/memory/ref_counted_memory.cc | 4 ++-- base/memory/ref_counted_memory.h | 5 +---- 2 files changed, 3 insertions(+), 6 deletions(-) (limited to 'base') diff --git a/base/memory/ref_counted_memory.cc b/base/memory/ref_counted_memory.cc index 59d141d..9bcde32 100644 --- a/base/memory/ref_counted_memory.cc +++ b/base/memory/ref_counted_memory.cc @@ -6,12 +6,12 @@ #include "base/logging.h" +namespace base { + RefCountedMemory::RefCountedMemory() {} RefCountedMemory::~RefCountedMemory() {} -namespace base { - const unsigned char* RefCountedStaticMemory::front() const { return data_; } diff --git a/base/memory/ref_counted_memory.h b/base/memory/ref_counted_memory.h index c9170f5..9c863c6 100644 --- a/base/memory/ref_counted_memory.h +++ b/base/memory/ref_counted_memory.h @@ -13,8 +13,7 @@ #include "base/compiler_specific.h" #include "base/memory/ref_counted.h" -// TODO(erg): The contents of this file should be in a namespace. This would -// require touching >100 files in chrome/ though. +namespace base { // A generic interface to memory. This object is reference counted because one // of its two subclasses own the data they carry, and we need to have @@ -35,8 +34,6 @@ class BASE_EXPORT RefCountedMemory virtual ~RefCountedMemory(); }; -namespace base { - // An implementation of RefCountedMemory, where the ref counting does not // matter. class BASE_EXPORT RefCountedStaticMemory : public RefCountedMemory { -- cgit v1.1