From 754bebc123ff35ecd50c68f43b7675953b1cb431 Mon Sep 17 00:00:00 2001 From: "sadrul@chromium.org" Date: Thu, 1 Dec 2011 16:42:16 +0000 Subject: aura: Fix unit_tests on linux Make sure the aura::Desktop is destroyed with the message-loop. This is done by adding a DestroyMessagePump notification to MessagePumpObserver. Also remove some views_unittests that were added to test NativeWidgetViews (which aren't used anymore), and do proper cleanup in AccessibilityEventRouter unittest. TBR=darin@chromium.org BUG=104559, 105613 TEST=unit_tests Review URL: http://codereview.chromium.org/8566037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112474 0039d316-1c4b-4281-b951-d872f2087c98 --- base/message_pump_x.cc | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) (limited to 'base') diff --git a/base/message_pump_x.cc b/base/message_pump_x.cc index 3b1ed3d..8a253df 100644 --- a/base/message_pump_x.cc +++ b/base/message_pump_x.cc @@ -183,6 +183,8 @@ bool MessagePumpX::RunOnce(GMainContext* context, bool block) { } bool MessagePumpX::WillProcessXEvent(XEvent* xevent) { + if (!observers().might_have_observers()) + return false; ObserverListBase::Iterator it(observers()); MessagePumpObserver* obs; while ((obs = it.GetNext()) != NULL) { @@ -193,11 +195,7 @@ bool MessagePumpX::WillProcessXEvent(XEvent* xevent) { } void MessagePumpX::DidProcessXEvent(XEvent* xevent) { - ObserverListBase::Iterator it(observers()); - MessagePumpObserver* obs; - while ((obs = it.GetNext()) != NULL) { - obs->DidProcessEvent(xevent); - } + FOR_EACH_OBSERVER(MessagePumpObserver, observers(), DidProcessEvent(xevent)); } } // namespace base -- cgit v1.1