From 75fee3776f2e159d8e52bb13bb4545ac46021512 Mon Sep 17 00:00:00 2001 From: "joi@chromium.org" Date: Wed, 6 Mar 2013 00:42:44 +0000 Subject: Introduce //components/user_prefs. The user_prefs component provides: a) The UserPrefs class, used to map PrefService objects to BrowserContext. This addresses a TODO to get rid of PrefServiceFromBrowserContext from base/prefs/pref_service.h, where clearly a mention of a content class did not belong. b) A place for PrefRegistrySyncable to live, where it can be used by components that need to register prefs. We also use (b) in this change to eliminate Autofill's dependency on chrome/browser/prefs. Work is ongoing to move Autofill to //components/autofill. TBR=ben@chromium.org BUG=155525,140037 Review URL: https://chromiumcodereview.appspot.com/12340111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186301 0039d316-1c4b-4281-b951-d872f2087c98 --- base/prefs/pref_service.cc | 2 -- base/prefs/pref_service.h | 10 ---------- 2 files changed, 12 deletions(-) (limited to 'base') diff --git a/base/prefs/pref_service.cc b/base/prefs/pref_service.cc index b1f4f3f..3b0e2cb 100644 --- a/base/prefs/pref_service.cc +++ b/base/prefs/pref_service.cc @@ -21,8 +21,6 @@ #include "base/value_conversions.h" #include "build/build_config.h" -using content::BrowserContext; - namespace { class ReadErrorHandler : public PersistentPrefStore::ReadErrorDelegate { diff --git a/base/prefs/pref_service.h b/base/prefs/pref_service.h index 9ba78be..d88dc91 100644 --- a/base/prefs/pref_service.h +++ b/base/prefs/pref_service.h @@ -36,10 +36,6 @@ namespace base { class FilePath; } -namespace content { -class BrowserContext; -} - namespace subtle { class PrefMemberBase; class ScopedUserPrefUpdateBase; @@ -355,10 +351,4 @@ class BASE_PREFS_EXPORT PrefService : public base::NonThreadSafe { DISALLOW_COPY_AND_ASSIGN(PrefService); }; -// Retrieves a PrefService for the given context. -// -// TODO(joi): This doesn't really belong here, since it references a -// content type; probably best to get rid of it completely. -PrefService* PrefServiceFromBrowserContext(content::BrowserContext* context); - #endif // BASE_PREFS_PREF_SERVICE_H_ -- cgit v1.1