From 9610ef248891f4be129eb915a43d226350569910 Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Wed, 18 Nov 2009 02:41:26 +0000 Subject: Launch processes asynchronously so as not to block the UI thread. For now, renderer only, I'll take care of plugin/worker/utility processes in a followup change. (relanding 32203) BUG=6844 Review URL: http://codereview.chromium.org/397031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32264 0039d316-1c4b-4281-b951-d872f2087c98 --- base/process_util_posix.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'base') diff --git a/base/process_util_posix.cc b/base/process_util_posix.cc index bfcd739..1148f6e 100644 --- a/base/process_util_posix.cc +++ b/base/process_util_posix.cc @@ -126,11 +126,9 @@ ProcessId GetProcId(ProcessHandle process) { // entry structure. Ignores specified exit_code; posix can't force that. // Returns true if this is successful, false otherwise. bool KillProcess(ProcessHandle process_id, int exit_code, bool wait) { - DCHECK(process_id > 1); - if (process_id <= 1) { - LOG(ERROR) << "tried to kill process_id " << process_id; + DCHECK_GT(process_id, 1) << " tried to kill invalid process_id"; + if (process_id <= 1) return false; - } bool result = kill(process_id, SIGTERM) == 0; -- cgit v1.1