From 86ee045d8a6deb903b0b614c67ac542f963d2be0 Mon Sep 17 00:00:00 2001 From: "brettw@chromium.org" Date: Fri, 11 Jul 2014 20:27:10 +0000 Subject: Make it possible for Android GN host builds to use Clang. The problem was that the toolchain definitions had an is_clang block in them, but this is only evaluated in the context of the default toolchain (so false for and Android build). But then when we were re-evaluating the build config for the host compile, it was forcing clang to true which was causing the clang flags to be set. This changes the way we default the is_clang value. Forcing it to true prevents it from being overridden manually. In some cases, like mac, this is pointless. In other cases like Linux, we may want to turn it on and off. Changing this definition allows us to toggle it on and off for different toolchains as we desire. Ideally I think the way of defining toolchains would be different to make this a bit more flexible, I'll think about this. But this will work for now. R=thakis@chromium.org Review URL: https://codereview.chromium.org/385823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282685 0039d316-1c4b-4281-b951-d872f2087c98 --- breakpad/BUILD.gn | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'breakpad') diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn index 596aea6..2c0ae49 100644 --- a/breakpad/BUILD.gn +++ b/breakpad/BUILD.gn @@ -516,7 +516,7 @@ if (is_linux && current_toolchain == host_toolchain) { if (is_clang) { # See http://crbug.com/138571#c18 - cflags += [ "-Wno-unused-value" ] + cflags = [ "-Wno-unused-value" ] } -- cgit v1.1