From fe4acac6ff5547d7674e6681c9b556528520fdf7 Mon Sep 17 00:00:00 2001 From: sbc Date: Fri, 17 Apr 2015 10:23:53 -0700 Subject: Always build dump_syms with the 'host' toolchain A recent change set linux_dump_symbols=1 on the trybots and was then reverted: https://codereview.chromium.org/1081103005 The causes the ARM/Linux builder to fail since it was attempting to run the target (ARM) dump_syms binary on x86. This change makes dump_syms a host binary so that it can run at build time. BUG=476781 TEST=linux_arm_compile trybot Review URL: https://codereview.chromium.org/1061473003 Cr-Commit-Position: refs/heads/master@{#325661} --- breakpad/breakpad.gyp | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'breakpad') diff --git a/breakpad/breakpad.gyp b/breakpad/breakpad.gyp index de0faac..cc5187d 100644 --- a/breakpad/breakpad.gyp +++ b/breakpad/breakpad.gyp @@ -447,11 +447,7 @@ # GN version: //breakpad:dump_syms 'target_name': 'dump_syms', 'type': 'executable', - 'conditions': [ - ['OS=="android"', { - 'toolsets': [ 'host' ], - }], - ], + 'toolsets': ['host'], # dwarf2reader.cc uses dynamic_cast. Because we don't typically # don't support RTTI, we enable it for this single target. Since -- cgit v1.1