From 7f8d486f3c2293482880ef53395d85698ea36b08 Mon Sep 17 00:00:00 2001 From: "thakis@chromium.org" Date: Tue, 5 Apr 2011 19:49:07 +0000 Subject: clang: Use -Wheader-hygiene instead of a custom check in the plugin. Revert the parts of http://codereview.chromium.org/6698051/ that added the custom plugin code, and use the new warning we added to upstream clang instead. Define U_USING_ICU_NAMESPACE=0 to make ICU not use |using namespace icu;| in its header and adapt cc files that use ICU. Depends on http://codereview.chromium.org/6691062 BUG=none TEST=none Review URL: http://codereview.chromium.org/6677115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80509 0039d316-1c4b-4281-b951-d872f2087c98 --- build/common.gypi | 2 ++ 1 file changed, 2 insertions(+) (limited to 'build/common.gypi') diff --git a/build/common.gypi b/build/common.gypi index 0a27489..3eab5ac 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -1248,6 +1248,7 @@ 'target_conditions': [ ['_toolset=="target"', { 'cflags': [ + '-Wheader-hygiene', # Clang spots more unused functions. '-Wno-unused-function', # Don't die on dtoa code that uses a char as an array index. @@ -1381,6 +1382,7 @@ ], ['clang==1', { 'WARNING_CFLAGS': [ + '-Wheader-hygiene', # Don't die on dtoa code that uses a char as an array index. # This is required solely for base/third_party/dmg_fp/dtoa.cc. '-Wno-char-subscripts', -- cgit v1.1