From 36df974f97c1d0c0ed935e3658995e90ab8fafe4 Mon Sep 17 00:00:00 2001 From: "rvargas@google.com" Date: Fri, 11 Nov 2011 00:55:00 +0000 Subject: Reland 109138 - GURL: Build the unit tests on the components build. BUG=102738 TEST=none Review URL: http://codereview.chromium.org/8496034 Review URL: http://codereview.chromium.org/8515025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109552 0039d316-1c4b-4281-b951-d872f2087c98 --- build/temp_gyp/googleurl.gyp | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) (limited to 'build/temp_gyp') diff --git a/build/temp_gyp/googleurl.gyp b/build/temp_gyp/googleurl.gyp index 3ed3eb7..8d61551 100644 --- a/build/temp_gyp/googleurl.gyp +++ b/build/temp_gyp/googleurl.gyp @@ -67,6 +67,7 @@ }, { 'target_name': 'googleurl_unittests', + 'type': 'executable', 'dependencies': [ 'googleurl', '../../base/base.gyp:base_i18n', @@ -94,15 +95,6 @@ }], ], }], - # TODO(victorw): The unittest code uses inline functions that access - # global variables, it also uses internal functions that we may not want - # to export, so skip building unittests for component builds. - # The googleurl functions are tested by the static library build. - ['component=="shared_library"', { - 'type': 'none', - }, { - 'type': 'executable', - }], ], }, ], -- cgit v1.1