From fa5da3e4e515967d593c3822b1d82f5e844080c5 Mon Sep 17 00:00:00 2001 From: scottmg Date: Wed, 10 Dec 2014 15:34:07 -0800 Subject: win gn: Semi-support for non-depot_tools toolchain I had to set: DEPOT_TOOLS_WIN_TOOLCHAIN=0 GYP_MSVS_OVERRIDE_PATH=C:/Program Files (x86)/Microsoft Visual Studio 12.0 GYP_MSVS_VERSION=2013 WindowsSdkDir=C:/Program Files (x86)/Windows Kits/8.1 then gn gen out\gn --args="is_debug=true cpu_arch=\"x86\"" ninja -C out/gn base worked OK. Further patches welcome to make this less ugly. R=dpranke@chromium.org Review URL: https://codereview.chromium.org/789303002 Cr-Commit-Position: refs/heads/master@{#307791} --- build/vs_toolchain.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'build/vs_toolchain.py') diff --git a/build/vs_toolchain.py b/build/vs_toolchain.py index fb7e142..5373f03 100644 --- a/build/vs_toolchain.py +++ b/build/vs_toolchain.py @@ -202,7 +202,7 @@ runtime_dirs = "%s" os.environ['WINDOWSSDKDIR'], os.environ['GYP_MSVS_VERSION'], os.environ.get('WDK_DIR', ''), - ';'.join(runtime_dll_dirs)) + ';'.join(runtime_dll_dirs or ['None'])) def main(): -- cgit v1.1