From 08fe51bbc9517c9ad95cac13fea9453ba6b380a0 Mon Sep 17 00:00:00 2001 From: "cbentzel@chromium.org" Date: Thu, 14 Oct 2010 10:48:56 +0000 Subject: Revert 62529 - Add -Wno-non-virtual-dtor flag on posix targets. I got my double negatives incorrect, this should have been -Wnon-virtual-dtor. BUG=45135 TEST=Targets build without error. Review URL: http://codereview.chromium.org/3527003 TBR=cbentzel@chromium.org Review URL: http://codereview.chromium.org/3756003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62531 0039d316-1c4b-4281-b951-d872f2087c98 --- build/common.gypi | 6 ------ 1 file changed, 6 deletions(-) (limited to 'build') diff --git a/build/common.gypi b/build/common.gypi index c376cb6..9f87a44 100644 --- a/build/common.gypi +++ b/build/common.gypi @@ -874,7 +874,6 @@ # Make inline functions have hidden visiblity by default. # Surprisingly, not covered by -fvisibility=hidden. '-fvisibility-inlines-hidden', - '-Wno-non-virtual-dtor', ], 'ldflags': [ '-pthread', '-Wl,-z,noexecstack', @@ -1238,11 +1237,6 @@ 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror 'GCC_VERSION': '4.2', 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof - # TODO(cbentzel): http://crbug.com/45135 - # Enable non virtual destructor warning on OSX. - # It's gcc implementation currently warns about more violations - # than Linux's gcc implementation. - #'GCC_WARN_NON_VIRTUAL_DESTRUCTOR': 'YES', # -Wno-non-virtual-dtor # MACOSX_DEPLOYMENT_TARGET maps to -mmacosx-version-min 'MACOSX_DEPLOYMENT_TARGET': '<(mac_deployment_target)', 'PREBINDING': 'NO', # No -Wl,-prebind -- cgit v1.1