From 6a8f5fe648c65ca74e8aa6b6b875280d60d5dce7 Mon Sep 17 00:00:00 2001 From: "sivachandra@chromium.org" Date: Wed, 16 Jan 2013 22:52:22 +0000 Subject: Add a presubmit check to check that a certain set of Android specific files only have deletions. We want certain Android specific files, like findbugs_known_bugs.txt, to only have deletions (not even modifications to existing lines). The presubmit check added in this CL checks that a certain list of files only have deletions. BUG=165608 NOTRY=True Review URL: https://chromiumcodereview.appspot.com/11583028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177241 0039d316-1c4b-4281-b951-d872f2087c98 --- build/android/PRESUBMIT.py | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) (limited to 'build') diff --git a/build/android/PRESUBMIT.py b/build/android/PRESUBMIT.py index f412c6b..fceeec3 100644 --- a/build/android/PRESUBMIT.py +++ b/build/android/PRESUBMIT.py @@ -8,6 +8,26 @@ See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for details on the presubmit API built into gcl. """ +_DELETIONS_ONLY_FILES = ( + 'build/android/findbugs_filter/findbugs_known_bugs.txt', +) + + +def _CheckDeletionsOnlyFiles(input_api, output_api): + """Check that a certain listed files only have deletions. + """ + errors = [] + for f in input_api.AffectedFiles(): + if f.LocalPath() in _DELETIONS_ONLY_FILES: + if f.ChangedContents(): + errors.append(f.LocalPath()) + results = [] + if errors: + results.append(output_api.PresubmitError( + 'Following files should only contain deletions.', errors)) + return results + + def CommonChecks(input_api, output_api): output = [] @@ -24,6 +44,7 @@ def CommonChecks(input_api, output_api): output.extend(input_api.canned_checks.RunUnitTestsInDirectory( input_api, output_api, J('buildbot', 'tests'))) + output.extend(_CheckDeletionsOnlyFiles(input_api, output_api)) return output -- cgit v1.1