From adbe30f035bfc0c63f763a2d4af165ea2d1cf9c0 Mon Sep 17 00:00:00 2001 From: "ernstm@chromium.org" Date: Fri, 11 Oct 2013 21:12:33 +0000 Subject: telemetry: Refactored rasterize_and_record measurement. - switched rasterize_and_record benchmark to new benchmark architecture. - detailled traces are not required anymore, fixing the issue with trace event buffer overflows. - changed output to show pixels rasterized and recorded for one iteration of the raster/record loop. - Further reduced variance by excluding lowres tiles and adding another sleep to the measurement. Stdev of pixel counts is now zero (except for amazon.com). Stdev of time metrics with 100 repetitions is well below 1% of the mean for most pages in the top_25. R=nduca@chromium.org BUG=280638 Review URL: https://codereview.chromium.org/25353009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228253 0039d316-1c4b-4281-b951-d872f2087c98 --- cc/debug/rendering_stats_instrumentation.h | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) (limited to 'cc/debug/rendering_stats_instrumentation.h') diff --git a/cc/debug/rendering_stats_instrumentation.h b/cc/debug/rendering_stats_instrumentation.h index fcecb37..4508600 100644 --- a/cc/debug/rendering_stats_instrumentation.h +++ b/cc/debug/rendering_stats_instrumentation.h @@ -19,11 +19,11 @@ class CC_EXPORT RenderingStatsInstrumentation { virtual ~RenderingStatsInstrumentation(); // Return current main thread rendering stats. - MainThreadRenderingStats GetMainThreadRenderingStats() { + const MainThreadRenderingStats& main_thread_rendering_stats() { return main_stats_; } // Return current impl thread rendering stats. - ImplThreadRenderingStats GetImplThreadRenderingStats() { + const ImplThreadRenderingStats& impl_thread_rendering_stats() { return impl_stats_; } // Return the accumulated, combined rendering stats. @@ -36,15 +36,6 @@ class CC_EXPORT RenderingStatsInstrumentation { // clear current stats. void AccumulateAndClearImplThreadStats(); - // Issue trace event for current main thread rendering stats. - void IssueTraceEventForMainThreadStats() { - main_stats_.IssueTraceEvent(); - } - // Issue trace event for current impl thread rendering stats. - void IssueTraceEventForImplThreadStats() { - impl_stats_.IssueTraceEvent(); - } - // Read and write access to the record_rendering_stats_ flag is not locked to // improve performance. The flag is commonly turned off and hardly changes // it's value during runtime. @@ -66,6 +57,7 @@ class CC_EXPORT RenderingStatsInstrumentation { RenderingStatsInstrumentation(); private: + // TODO(ernstm): rename to *_thread_rendering_stats_* MainThreadRenderingStats main_stats_; MainThreadRenderingStats main_stats_accu_; ImplThreadRenderingStats impl_stats_; -- cgit v1.1