From 2a58e14322fb357f248528b4b4c77e10fa53ae2d Mon Sep 17 00:00:00 2001 From: "mnissler@chromium.org" Date: Tue, 28 Jan 2014 11:42:39 +0000 Subject: Revert of [#7] Pass gfx structs by const ref (gfx::Size) (https://codereview.chromium.org/145313006/) Reason for revert: Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 ) Original issue's description: > [#7] Pass gfx::Size by const ref. > > Any struct of size > 4 bytes should be passed by const ref. > Passing by ref for these structs is faster than passing by value, > especially when invoking function has multiple parameters and some > other scenarios mentioned in the bug. > > BUG=159273 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426 TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com NOTREECHECKS=true NOTRY=true BUG=159273 Review URL: https://codereview.chromium.org/142863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98 --- cc/layers/delegated_renderer_layer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cc/layers/delegated_renderer_layer.h') diff --git a/cc/layers/delegated_renderer_layer.h b/cc/layers/delegated_renderer_layer.h index a0b67df..dc9dfee 100644 --- a/cc/layers/delegated_renderer_layer.h +++ b/cc/layers/delegated_renderer_layer.h @@ -33,7 +33,7 @@ class CC_EXPORT DelegatedRendererLayer : public Layer { // layer's origin. This must always contain at least the layer's bounds. A // value of (0, 0) implies that the frame should be displayed to fit exactly // in the layer's bounds. - void SetDisplaySize(const gfx::Size& size); + void SetDisplaySize(gfx::Size size); // Called by the DelegatedFrameProvider when a new frame is available to be // picked up. -- cgit v1.1