From 0023fc78d056556b353ee17f03760bec8c1fee49 Mon Sep 17 00:00:00 2001 From: "prashant.n@samsung.com" Date: Fri, 10 Jan 2014 20:05:06 +0000 Subject: Pass gfx::Rect and gfx::RectF by const ref. Avoid unneccessary copy of structures gfx::Rect & gfx::RectF by passing them by const ref rather than value. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters. Pass by value creates unneccessary overhead which should be avoided. BUG=159273 Review URL: https://codereview.chromium.org/93663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98 --- cc/output/delegating_renderer.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'cc/output/delegating_renderer.h') diff --git a/cc/output/delegating_renderer.h b/cc/output/delegating_renderer.h index c18bfa7..3de65f7 100644 --- a/cc/output/delegating_renderer.h +++ b/cc/output/delegating_renderer.h @@ -31,8 +31,8 @@ class CC_EXPORT DelegatingRenderer : public Renderer { virtual void DrawFrame(RenderPassList* render_passes_in_draw_order, ContextProvider* offscreen_context_provider, float device_scale_factor, - gfx::Rect device_viewport_rect, - gfx::Rect device_clip_rect, + const gfx::Rect& device_viewport_rect, + const gfx::Rect& device_clip_rect, bool allow_partial_swap, bool disable_picture_quad_image_filtering) OVERRIDE; @@ -41,7 +41,8 @@ class CC_EXPORT DelegatingRenderer : public Renderer { virtual void SwapBuffers(const CompositorFrameMetadata& metadata) OVERRIDE; virtual void ReceiveSwapBuffersAck(const CompositorFrameAck&) OVERRIDE; - virtual void GetFramebufferPixels(void* pixels, gfx::Rect rect) OVERRIDE; + virtual void GetFramebufferPixels(void* pixels, + const gfx::Rect& rect) OVERRIDE; virtual bool IsContextLost() OVERRIDE; -- cgit v1.1