From 2a58e14322fb357f248528b4b4c77e10fa53ae2d Mon Sep 17 00:00:00 2001 From: "mnissler@chromium.org" Date: Tue, 28 Jan 2014 11:42:39 +0000 Subject: Revert of [#7] Pass gfx structs by const ref (gfx::Size) (https://codereview.chromium.org/145313006/) Reason for revert: Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 ) Original issue's description: > [#7] Pass gfx::Size by const ref. > > Any struct of size > 4 bytes should be passed by const ref. > Passing by ref for these structs is faster than passing by value, > especially when invoking function has multiple parameters and some > other scenarios mentioned in the bug. > > BUG=159273 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426 TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com NOTREECHECKS=true NOTRY=true BUG=159273 Review URL: https://codereview.chromium.org/142863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98 --- cc/resources/scoped_resource.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'cc/resources/scoped_resource.cc') diff --git a/cc/resources/scoped_resource.cc b/cc/resources/scoped_resource.cc index a320bab..99f93c9 100644 --- a/cc/resources/scoped_resource.cc +++ b/cc/resources/scoped_resource.cc @@ -15,7 +15,7 @@ ScopedResource::~ScopedResource() { Free(); } -void ScopedResource::Allocate(const gfx::Size& size, +void ScopedResource::Allocate(gfx::Size size, ResourceProvider::TextureUsageHint hint, ResourceFormat format) { DCHECK(!id()); @@ -30,7 +30,7 @@ void ScopedResource::Allocate(const gfx::Size& size, #endif } -void ScopedResource::AllocateManaged(const gfx::Size& size, +void ScopedResource::AllocateManaged(gfx::Size size, GLenum target, ResourceFormat format) { DCHECK(!id()); -- cgit v1.1