From 0023fc78d056556b353ee17f03760bec8c1fee49 Mon Sep 17 00:00:00 2001 From: "prashant.n@samsung.com" Date: Fri, 10 Jan 2014 20:05:06 +0000 Subject: Pass gfx::Rect and gfx::RectF by const ref. Avoid unneccessary copy of structures gfx::Rect & gfx::RectF by passing them by const ref rather than value. Any struct of size > 4 bytes should be passed by const ref. Passing by ref for these structs is faster than passing by value, especially when invoking function has multiple parameters. Pass by value creates unneccessary overhead which should be avoided. BUG=159273 Review URL: https://codereview.chromium.org/93663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244224 0039d316-1c4b-4281-b951-d872f2087c98 --- cc/test/fake_content_layer_client.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cc/test/fake_content_layer_client.cc') diff --git a/cc/test/fake_content_layer_client.cc b/cc/test/fake_content_layer_client.cc index af70c0c..563e945 100644 --- a/cc/test/fake_content_layer_client.cc +++ b/cc/test/fake_content_layer_client.cc @@ -17,7 +17,7 @@ FakeContentLayerClient::~FakeContentLayerClient() { } void FakeContentLayerClient::PaintContents(SkCanvas* canvas, - gfx::Rect paint_rect, gfx::RectF* opaque_rect) { + const gfx::Rect& paint_rect, gfx::RectF* opaque_rect) { if (paint_all_opaque_) *opaque_rect = paint_rect; -- cgit v1.1