From 2a58e14322fb357f248528b4b4c77e10fa53ae2d Mon Sep 17 00:00:00 2001 From: "mnissler@chromium.org" Date: Tue, 28 Jan 2014 11:42:39 +0000 Subject: Revert of [#7] Pass gfx structs by const ref (gfx::Size) (https://codereview.chromium.org/145313006/) Reason for revert: Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 ) Original issue's description: > [#7] Pass gfx::Size by const ref. > > Any struct of size > 4 bytes should be passed by const ref. > Passing by ref for these structs is faster than passing by value, > especially when invoking function has multiple parameters and some > other scenarios mentioned in the bug. > > BUG=159273 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426 TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com NOTREECHECKS=true NOTRY=true BUG=159273 Review URL: https://codereview.chromium.org/142863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98 --- cc/test/fake_picture_layer_impl.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'cc/test/fake_picture_layer_impl.h') diff --git a/cc/test/fake_picture_layer_impl.h b/cc/test/fake_picture_layer_impl.h index 477b6b9..a289934 100644 --- a/cc/test/fake_picture_layer_impl.h +++ b/cc/test/fake_picture_layer_impl.h @@ -26,8 +26,7 @@ class FakePictureLayerImpl : public PictureLayerImpl { OVERRIDE; virtual void AppendQuads(QuadSink* quad_sink, AppendQuadsData* append_quads_data) OVERRIDE; - virtual gfx::Size CalculateTileSize( - const gfx::Size& content_bounds) const OVERRIDE; + virtual gfx::Size CalculateTileSize(gfx::Size content_bounds) const OVERRIDE; using PictureLayerImpl::AddTiling; using PictureLayerImpl::CleanUpTilingsOnActiveLayer; @@ -55,7 +54,7 @@ class FakePictureLayerImpl : public PictureLayerImpl { const Region& invalidation() const { return invalidation_; } void set_invalidation(const Region& region) { invalidation_ = region; } - void set_fixed_tile_size(const gfx::Size& size) { fixed_tile_size_ = size; } + void set_fixed_tile_size(gfx::Size size) { fixed_tile_size_ = size; } void CreateDefaultTilingsAndTiles(); void SetAllTilesVisible(); -- cgit v1.1