From 2a58e14322fb357f248528b4b4c77e10fa53ae2d Mon Sep 17 00:00:00 2001 From: "mnissler@chromium.org" Date: Tue, 28 Jan 2014 11:42:39 +0000 Subject: Revert of [#7] Pass gfx structs by const ref (gfx::Size) (https://codereview.chromium.org/145313006/) Reason for revert: Suspected of breaking the Linux ASAN tests ( http://build.chromium.org/p/chromium.memory/builders/Linux%20ASAN%20Tests%20%283%29/builds/22104 ) Original issue's description: > [#7] Pass gfx::Size by const ref. > > Any struct of size > 4 bytes should be passed by const ref. > Passing by ref for these structs is faster than passing by value, > especially when invoking function has multiple parameters and some > other scenarios mentioned in the bug. > > BUG=159273 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247426 TBR=danakj@chromium.org,enne@chromium.org,bulach@chromium.org,piman@chromium.org,prashant.n@samsung.com NOTREECHECKS=true NOTRY=true BUG=159273 Review URL: https://codereview.chromium.org/142863008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247437 0039d316-1c4b-4281-b951-d872f2087c98 --- cc/test/layer_tree_pixel_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cc/test/layer_tree_pixel_test.cc') diff --git a/cc/test/layer_tree_pixel_test.cc b/cc/test/layer_tree_pixel_test.cc index c5d2125..806b877 100644 --- a/cc/test/layer_tree_pixel_test.cc +++ b/cc/test/layer_tree_pixel_test.cc @@ -228,7 +228,7 @@ void LayerTreePixelTest::SetupTree() { } scoped_ptr LayerTreePixelTest::CopyTextureMailboxToBitmap( - const gfx::Size& size, + gfx::Size size, const TextureMailbox& texture_mailbox) { DCHECK(texture_mailbox.IsTexture()); if (!texture_mailbox.IsTexture()) -- cgit v1.1