From ab27776efc9e3ec19e0f8f8a489d670ee800eb75 Mon Sep 17 00:00:00 2001 From: Dana Jansens Date: Fri, 12 Jun 2015 16:52:55 -0700 Subject: cc: Remove the non-implside flavour of LayerTreeTests. While doing so I audited a bunch of MULTI_THREAD only tests and turned them into SINGLE_AND_MULTI_THREAD or documented why not to. Some of the NOIMPL tests really are NOIMPL and I deleted them. The others I turned on with impl-side instead. NOTE TO PERF SHERIFFS: This changes the names of some cc_perftests and makes some of them use impl-side painting now. If this has perf side- effects these should be considered new (more accurate) baselines. R=enne@chromium.org, enne, vmpstr BUG=413479 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1180613010. Cr-Commit-Position: refs/heads/master@{#334286} --- cc/trees/layer_tree_host_unittest_proxy.cc | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) (limited to 'cc/trees/layer_tree_host_unittest_proxy.cc') diff --git a/cc/trees/layer_tree_host_unittest_proxy.cc b/cc/trees/layer_tree_host_unittest_proxy.cc index 3135103..66340e7 100644 --- a/cc/trees/layer_tree_host_unittest_proxy.cc +++ b/cc/trees/layer_tree_host_unittest_proxy.cc @@ -7,16 +7,8 @@ #include "cc/test/layer_tree_test.h" #include "cc/trees/thread_proxy.h" -#define THREAD_PROXY_NO_IMPL_TEST_F(TEST_FIXTURE_NAME) \ - TEST_F(TEST_FIXTURE_NAME, Run_MainThreadPaint) { \ - Run(true, false); \ - } - -#define THREAD_PROXY_TEST_F(TEST_FIXTURE_NAME) \ - THREAD_PROXY_NO_IMPL_TEST_F(TEST_FIXTURE_NAME); \ - TEST_F(TEST_FIXTURE_NAME, Run_ImplSidePaint) { \ - Run(true, true); \ - } +#define THREAD_PROXY_TEST_F(TEST_FIXTURE_NAME) \ + TEST_F(TEST_FIXTURE_NAME, MultiThread) { Run(true); } // Do common tests for single thread proxy and thread proxy. // TODO(simonhong): Add SINGLE_THREAD_PROXY_TEST_F @@ -30,11 +22,11 @@ class ProxyTest : public LayerTreeTest { ProxyTest() {} ~ProxyTest() override {} - void Run(bool threaded, bool impl_side_painting) { + void Run(bool threaded) { // We don't need to care about delegating mode. bool delegating_renderer = true; - RunTest(threaded, delegating_renderer, impl_side_painting); + RunTest(threaded, delegating_renderer); } void BeginTest() override {} -- cgit v1.1