From 487bd7a0764234e6f88be3512a5acb6350e6de36 Mon Sep 17 00:00:00 2001 From: "mrossetti@chromium.org" Date: Thu, 19 Nov 2009 00:06:04 +0000 Subject: Change the folder presentation in the Bookmark Editor and the Bookmark All Tabs dialogs to a tree view. Nib changes: Removed the NSBrowser and added an NSOutlineView. BUG=26647,26643,26718,27634 TEST=Bring up the bookmark editor by control-clicking in the bookmarks bar and selecting Add Page... or by selecting the Bookmark this Page... menu item found in the Bookmarks menu. Observe that the folder presentation is now a tree view. Select any folder and click New Folder to verify that new folders can be added. Double-click on the newly created folder to change its name. Added folders will not commit until OK is pressed, which will require that a bookmark actually be added. Also bring up the Bookmark All Tabs dialog by control-clicking in the tab bar with more than one tab open and verify that the folder structure is shown in a tree view. Review URL: http://codereview.chromium.org/393006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32441 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/app/nibs/BookmarkAllTabs.xib | 458 +++++++++++++++++++++++++++++------- chrome/app/nibs/BookmarkEditor.xib | 449 +++++++++++++++++++++++++++-------- 2 files changed, 718 insertions(+), 189 deletions(-) (limited to 'chrome/app') diff --git a/chrome/app/nibs/BookmarkAllTabs.xib b/chrome/app/nibs/BookmarkAllTabs.xib index 09e68a6..db46a9f 100644 --- a/chrome/app/nibs/BookmarkAllTabs.xib +++ b/chrome/app/nibs/BookmarkAllTabs.xib @@ -1,9 +1,9 @@ - + 1050 - 9L30 - 670 + 9L31a + 677 949.54 353.00 @@ -14,6 +14,15 @@ YES com.apple.InterfaceBuilder.CocoaPlugin + + YES + + YES + + + YES + + YES @@ -26,7 +35,7 @@ NSApplication - 15 + 9 2 {{196, 257}, {480, 253}} 536870912 @@ -40,30 +49,6 @@ 256 YES - - - 274 - {{20, 60}, {440, 143}} - - YES - - 67239488 - 2048 - - - LucidaGrande - 1.200000e+01 - 16 - - - / - 100 - 3 - 1 - 1.000000e+02 - YES - 1544765440 - 289 @@ -139,12 +124,12 @@ 6 System controlColor - + 3 MC42NjY2NjY2OQA - + 6 System controlTextColor @@ -207,7 +192,7 @@ 6 System textBackgroundColor - + 3 MQA @@ -220,6 +205,156 @@ + + + 274 + + YES + + + 2304 + + YES + + + 256 + {423, 114} + + YES + + + 256 + {423, 17} + + + + + + 256 + {{424, 0}, {16, 17}} + + + + YES + + 4.200000e+02 + 1.600000e+01 + 1.000000e+03 + + 75628032 + 0 + + + LucidaGrande + 1.100000e+01 + 3100 + + + 3 + MC4zMzMzMzI5OQA + + + 6 + System + headerTextColor + + + + + 337772096 + 2048 + Text Cell + + + + 6 + System + controlBackgroundColor + + + + + 3 + YES + YES + + + + 3.000000e+00 + 2.000000e+00 + + + 6 + System + gridColor + + 3 + MC41AA + + + 1.700000e+01 + 306184192 + 5 + 15 + 0 + YES + + + {{1, 17}, {423, 114}} + + + + + 4 + + + + 256 + {{424, 17}, {15, 114}} + + + _doScroller: + 3.700000e+01 + 1.390978e-01 + + + + 256 + {{1, 131}, {423, 15}} + + 1 + + _doScroller: + 1.000000e+00 + 9.837210e-01 + + + + 2304 + + YES + + + {{1, 0}, {423, 17}} + + + + + 4 + + + + {{20, 52}, {440, 147}} + + + 50 + + + + + + QSAAAEEgAABBmAAAQZgAAA + {480, 253} @@ -234,6 +369,20 @@ GTMUILocalizerAndLayoutTweaker + + + YES + folderName + newFolder + selectionIndexPaths + + YES + + YES + YES + YES + children + @@ -319,30 +468,6 @@ 41 - - folderBrowser_ - - - - 59 - - - - delegate - - - - 60 - - - - target - - - - 61 - - value: displayName @@ -378,13 +503,118 @@ 66 + + + folderTreeController_ + + + + 75 + + + + contentArray: folderTreeArray + + + + + + contentArray: folderTreeArray + contentArray + folderTreeArray + 2 + + + 76 + + + + fontBold: arrangedObjects.newFolder + + + + + + fontBold: arrangedObjects.newFolder + fontBold + arrangedObjects.newFolder + 2 + + + 80 + + + + editable: arrangedObjects.newFolder + + + + + + editable: arrangedObjects.newFolder + editable + arrangedObjects.newFolder + 2 + + + 81 + + + + value: arrangedObjects.folderName + + + + + + value: arrangedObjects.folderName + value + arrangedObjects.folderName + 2 + + + 82 + + + + content: arrangedObjects + + + + + + content: arrangedObjects + content + arrangedObjects + 2 + + + 84 + + + + selectionIndexPaths: tableSelectionPaths + + + + + + selectionIndexPaths: tableSelectionPaths + selectionIndexPaths + tableSelectionPaths + + 2 + + + 85 + YES 0 - + YES @@ -393,19 +623,19 @@ -2 - + RmlsZSdzIE93bmVyA -1 - + First Responder -3 - + Application @@ -415,31 +645,25 @@ YES - + 2 YES - + - 26 - - - Folder Tree Browser - - 34 - + 36 @@ -482,7 +706,7 @@ 37 - + 40 @@ -531,6 +755,62 @@ + 67 + + + YES + + + + + + + + + 68 + + + + + 69 + + + YES + + + + + + 70 + + + + + 71 + + + + + 72 + + + YES + + + + + + 73 + + + + + 74 + + + Folder Tree Controller + + 13 @@ -569,14 +849,21 @@ 14.IBPluginDependency 2.IBPluginDependency 2.IBUserGuides - 26.IBPluginDependency 3.IBPluginDependency 34.IBPluginDependency 37.IBPluginDependency 4.IBPluginDependency 5.IBPluginDependency 6.IBPluginDependency + 67.IBPluginDependency + 68.IBPluginDependency + 69.IBPluginDependency 7.IBPluginDependency + 70.IBPluginDependency + 71.IBPluginDependency + 72.IBPluginDependency + 73.IBPluginDependency + 74.IBPluginDependency 8.IBPluginDependency 9.IBPluginDependency @@ -585,10 +872,10 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - {{141, 575}, {480, 253}} + {{445, 603}, {480, 253}} com.apple.InterfaceBuilder.CocoaPlugin - {{141, 575}, {480, 253}} + {{445, 603}, {480, 253}} {196, 240} {{357, 418}, {480, 270}} @@ -613,6 +900,13 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin @@ -635,7 +929,7 @@ - 66 + 85 @@ -670,13 +964,15 @@ YES YES - folderBrowser_ + folderTreeController_ + folderTreeView_ newFolderButton_ okButton_ YES - NSBrowser + NSTreeController + NSOutlineView NSButton NSButton @@ -761,18 +1057,6 @@ - NSBrowser - NSControl - - target - id - - - IBUserSource - - - - NSObject IBProjectSource diff --git a/chrome/app/nibs/BookmarkEditor.xib b/chrome/app/nibs/BookmarkEditor.xib index 312cafd..71e4ab9 100644 --- a/chrome/app/nibs/BookmarkEditor.xib +++ b/chrome/app/nibs/BookmarkEditor.xib @@ -1,19 +1,28 @@ - + 1050 - 9L30 - 670 + 9L31a + 677 949.54 353.00 YES - + YES com.apple.InterfaceBuilder.CocoaPlugin + + YES + + YES + + + YES + + YES @@ -40,30 +49,6 @@ 256 YES - - - 274 - {{20, 60}, {440, 143}} - - YES - - 67239488 - 2048 - - - LucidaGrande - 1.200000e+01 - 16 - - - / - 100 - 3 - 1 - 1.000000e+02 - YES - 1544765440 - 289 @@ -139,7 +124,7 @@ 6 System controlColor - + 3 MC42NjY2NjY2OQA @@ -203,7 +188,7 @@ 6 System textBackgroundColor - + 3 MQA @@ -245,7 +230,7 @@ 67239424 0 - + LucidaGrande 1.100000e+01 3100 @@ -293,6 +278,125 @@ GTMWidthBasedTweaker + + + 274 + + YES + + + 2304 + + YES + + + 274 + {423, 122} + + YES + + + 256 + {{424, 0}, {16, 17}} + + + YES + + 4.040000e+02 + 1.600000e+01 + 1.000000e+03 + + 75628032 + 0 + + + + 3 + MC4zMzMzMzI5OQA + + + 6 + System + headerTextColor + + + + + 337772096 + 2048 + Text Cell + + + + 6 + System + controlBackgroundColor + + + + + 3 + YES + YES + + + + 3.000000e+00 + 2.000000e+00 + + + 6 + System + gridColor + + 3 + MC41AA + + + 1.700000e+01 + 37748736 + 4 + 15 + 0 + YES + + + {{1, 1}, {423, 122}} + + + + + 4 + + + + 256 + {{424, 1}, {15, 122}} + + + _doScroller: + 9.918699e-01 + + + + 256 + {{1, 123}, {423, 15}} + + 1 + + _doScroller: + 9.976415e-01 + + + {{20, 51}, {440, 139}} + + + 50 + + + + QSAAAEEgAABBmAAAQZgAAA + {480, 270} @@ -307,6 +411,16 @@ GTMUILocalizerAndLayoutTweaker + + + YES + folderName + newFolder + + + YES + children + @@ -337,14 +451,6 @@ - urlField_ - - - - 25 - - - window @@ -408,30 +514,6 @@ 43 - - folderBrowser_ - - - - 59 - - - - delegate - - - - 60 - - - - target - - - - 61 - - value: displayURL @@ -487,13 +569,126 @@ 66 + + + contentArray: folderTreeArray + + + + + + contentArray: folderTreeArray + contentArray + folderTreeArray + 2 + + + 78 + + + + value: arrangedObjects.folderName + + + + + + value: arrangedObjects.folderName + value + arrangedObjects.folderName + 2 + + + 80 + + + + folderTreeController_ + + + + 90 + + + + folderTreeView_ + + + + 91 + + + + fontBold: arrangedObjects.newFolder + + + + + + fontBold: arrangedObjects.newFolder + fontBold + arrangedObjects.newFolder + 2 + + + 98 + + + + editable: arrangedObjects.newFolder + + + + + + editable: arrangedObjects.newFolder + editable + arrangedObjects.newFolder + 2 + + + 101 + + + + content: arrangedObjects + + + + + + content: arrangedObjects + content + arrangedObjects + 2 + + + 102 + + + + selectionIndexPaths: tableSelectionPaths + + + + + + selectionIndexPaths: tableSelectionPaths + selectionIndexPaths + tableSelectionPaths + + 2 + + + 111 + YES 0 - + YES @@ -502,19 +697,19 @@ -2 - + RmlsZSdzIE93bmVyA -1 - + First Responder -3 - + Application @@ -524,31 +719,25 @@ YES - + 2 YES - - + + - 26 - - - Folder Tree Browser - - 34 - + 36 @@ -591,7 +780,7 @@ 37 - + 40 @@ -692,6 +881,56 @@ + + 67 + + + YES + + + + + + + + 68 + + + + + 69 + + + + + 70 + + + YES + + + + + + 72 + + + YES + + + + + + 75 + + + + + 76 + + + Folder Tree Controller + @@ -721,14 +960,20 @@ 16.IBPluginDependency 2.IBPluginDependency 2.IBUserGuides - 26.IBPluginDependency 3.IBPluginDependency 34.IBPluginDependency 37.IBPluginDependency 4.IBPluginDependency 5.IBPluginDependency 6.IBPluginDependency + 67.IBPluginDependency + 68.IBPluginDependency + 69.IBPluginDependency 7.IBPluginDependency + 70.IBPluginDependency + 72.IBPluginDependency + 75.IBPluginDependency + 76.IBPluginDependency 8.IBPluginDependency 9.IBPluginDependency @@ -737,15 +982,15 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin - {{141, 558}, {480, 270}} + {{510, 586}, {480, 270}} com.apple.InterfaceBuilder.CocoaPlugin - {{141, 558}, {480, 270}} + {{510, 586}, {480, 270}} {196, 240} {{357, 418}, {480, 270}} - + {331, 270} {331, 270} com.apple.InterfaceBuilder.CocoaPlugin @@ -769,6 +1014,12 @@ com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin + com.apple.InterfaceBuilder.CocoaPlugin @@ -791,13 +1042,13 @@ - 66 + 111 YES - BookmarkEditorController + BookmarkEditorBaseController NSWindowController YES @@ -818,23 +1069,29 @@ YES YES - folderBrowser_ - nameField_ + folderTreeController_ + folderTreeView_ newFolderButton_ okButton_ - urlField_ YES - NSBrowser - NSTextField + NSTreeController + NSOutlineView NSButton NSButton - NSTextField IBProjectSource + browser/cocoa/bookmark_editor_base_controller.h + + + + BookmarkEditorController + BookmarkEditorBaseController + + IBProjectSource browser/cocoa/bookmark_editor_controller.h @@ -913,18 +1170,6 @@ - NSBrowser - NSControl - - target - id - - - IBUserSource - - - - NSObject IBProjectSource -- cgit v1.1