From 3690ebe09a8c3cea0fd7d9ece8f5b8d8ebc65c19 Mon Sep 17 00:00:00 2001 From: "hans@chromium.org" Date: Wed, 25 May 2011 09:08:19 +0000 Subject: Virtual destructors should have virtual keyword. Make sure user-declared virtual destructors always have the virtual keyword. The Clang style-check plugin will check for this soon. No functionality change: virtual is only added to destructors that are already implicitly virtual. Also fix a couple of in-line destructor definitions. BUG=83408 TEST=none Review URL: http://codereview.chromium.org/7064033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86587 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/autocomplete/autocomplete_edit.h | 2 +- chrome/browser/autocomplete/autocomplete_popup_view_gtk.h | 2 +- chrome/browser/autocomplete/history_contents_provider.h | 2 +- chrome/browser/autocomplete/history_quick_provider.h | 2 +- chrome/browser/autocomplete/search_provider.h | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) (limited to 'chrome/browser/autocomplete') diff --git a/chrome/browser/autocomplete/autocomplete_edit.h b/chrome/browser/autocomplete/autocomplete_edit.h index 9d3f8b8..1da8241 100644 --- a/chrome/browser/autocomplete/autocomplete_edit.h +++ b/chrome/browser/autocomplete/autocomplete_edit.h @@ -103,7 +103,7 @@ class AutocompleteEditModel : public AutocompleteControllerDelegate { AutocompleteEditModel(OmniboxView* view, AutocompleteEditController* controller, Profile* profile); - ~AutocompleteEditModel(); + virtual ~AutocompleteEditModel(); AutocompleteController* autocomplete_controller() const { return autocomplete_controller_.get(); diff --git a/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h b/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h index 7152fa2..2f3eda3 100644 --- a/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h +++ b/chrome/browser/autocomplete/autocomplete_popup_view_gtk.h @@ -36,7 +36,7 @@ class AutocompletePopupViewGtk : public AutocompletePopupView, AutocompleteEditModel* edit_model, Profile* profile, GtkWidget* location_bar); - ~AutocompletePopupViewGtk(); + virtual ~AutocompletePopupViewGtk(); // Overridden from AutocompletePopupView: virtual bool IsOpen() const; diff --git a/chrome/browser/autocomplete/history_contents_provider.h b/chrome/browser/autocomplete/history_contents_provider.h index e4279a1..7ceb0b9 100644 --- a/chrome/browser/autocomplete/history_contents_provider.h +++ b/chrome/browser/autocomplete/history_contents_provider.h @@ -35,7 +35,7 @@ class HistoryContentsProvider : public HistoryProvider { virtual void Stop() OVERRIDE; private: - ~HistoryContentsProvider(); + virtual ~HistoryContentsProvider(); void QueryComplete(HistoryService::Handle handle, history::QueryResults* results); diff --git a/chrome/browser/autocomplete/history_quick_provider.h b/chrome/browser/autocomplete/history_quick_provider.h index 69c7dc8..20cd5df 100644 --- a/chrome/browser/autocomplete/history_quick_provider.h +++ b/chrome/browser/autocomplete/history_quick_provider.h @@ -28,7 +28,7 @@ class HistoryQuickProvider : public HistoryProvider { public: HistoryQuickProvider(ACProviderListener* listener, Profile* profile); - ~HistoryQuickProvider(); + virtual ~HistoryQuickProvider(); // AutocompleteProvider. |minimal_changes| is ignored since there // is no asynch completion performed. diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h index e627cb4..2a62236 100644 --- a/chrome/browser/autocomplete/search_provider.h +++ b/chrome/browser/autocomplete/search_provider.h @@ -82,7 +82,7 @@ class SearchProvider : public AutocompleteProvider, static const int kKeywordProviderURLFetcherID; private: - ~SearchProvider(); + virtual ~SearchProvider(); // Manages the providers (TemplateURLs) used by SearchProvider. Two providers // may be used: -- cgit v1.1