From 9026425611e977156f61129d99d53779c0619570 Mon Sep 17 00:00:00 2001 From: "deanm@chromium.org" Date: Thu, 12 Mar 2009 11:16:01 +0000 Subject: Fix a Linux Omnibox bug where a widget was used after it was destroyed. Review URL: http://codereview.chromium.org/42073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11528 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'chrome/browser/autocomplete') diff --git a/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc b/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc index 42f57aa..94a5cdf 100755 --- a/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc +++ b/chrome/browser/autocomplete/autocomplete_popup_view_gtk.cc @@ -45,6 +45,10 @@ AutocompletePopupViewGtk::AutocompletePopupViewGtk( } AutocompletePopupViewGtk::~AutocompletePopupViewGtk() { + // Explicitly destroy our model here, before we destroy our GTK widgets. + // This is because the model destructor can call back into us, and we need + // to make sure everything is still valid when it does. + model_.reset(); if (vbox_) gtk_widget_destroy(vbox_); gtk_widget_destroy(window_); -- cgit v1.1