From d85cf074f2186dbe1cf8a9db5d89a2b817ffb0e1 Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Tue, 27 Oct 2009 03:59:31 +0000 Subject: Simplify threading in browser thread by making only ChromeThread deal with different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354 Review URL: http://codereview.chromium.org/306032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/autocomplete/search_provider_unittest.cc | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'chrome/browser/autocomplete') diff --git a/chrome/browser/autocomplete/search_provider_unittest.cc b/chrome/browser/autocomplete/search_provider_unittest.cc index 493df22..b5f9bcd 100644 --- a/chrome/browser/autocomplete/search_provider_unittest.cc +++ b/chrome/browser/autocomplete/search_provider_unittest.cc @@ -6,6 +6,7 @@ #include "base/time.h" #include "build/build_config.h" #include "chrome/browser/autocomplete/search_provider.h" +#include "chrome/browser/chrome_thread.h" #include "chrome/browser/history/history.h" #include "chrome/browser/net/test_url_fetcher_factory.h" #include "chrome/browser/search_engines/template_url.h" @@ -31,7 +32,10 @@ class SearchProviderTest : public testing::Test, term1_(L"term1"), keyword_t_url_(NULL), keyword_term_(L"keyword"), - quit_when_done_(false) {} + io_thread_(ChromeThread::IO), + quit_when_done_(false) { + io_thread_.Start(); + } // See description above class for what this registers. virtual void SetUp(); @@ -62,11 +66,12 @@ class SearchProviderTest : public testing::Test, const std::wstring keyword_term_; GURL keyword_url_; + MessageLoopForUI message_loop_; + ChromeThread io_thread_; + // URLFetcher::Factory implementation registered. TestURLFetcherFactory test_factory_; - MessageLoopForUI message_loop_; - // Profile we use. TestingProfile profile_; -- cgit v1.1