From fcfece45185268c1a55260a1d5c0abfbceaffe1f Mon Sep 17 00:00:00 2001 From: "isherman@chromium.org" Date: Fri, 22 Jul 2011 08:29:32 +0000 Subject: Consolidate Autofill possible type detection code, and enforce greater match precision. * Only consider submitted field values to match locally stored data if the strings match exactly + This means we will send fewer false positives to the server, at the cost of some false negatives. Most importantly, we should stop identifying ADDRESS_LINE_2 fields as ADDRESS_LINE_1. + There are a few excpetions for structured fields with canonicalized values, like countries (which are canonicalized to country codes) * Eliminate FormGroup::GetMatchingTypes() -- all of this work is now done in a consistent way within AutofillManager * Refactor FormGroup::GetNonEmptyTypes() to be shared code. BUG=81867, 76992 TEST=unit_tests --gtest_filter=AutofillManagerTest.DeterminePossibleFieldTypesForUpload Review URL: http://codereview.chromium.org/7398019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93582 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/autofill/phone_number_i18n.cc | 1 - 1 file changed, 1 deletion(-) (limited to 'chrome/browser/autofill/phone_number_i18n.cc') diff --git a/chrome/browser/autofill/phone_number_i18n.cc b/chrome/browser/autofill/phone_number_i18n.cc index c26f7c5..1ad2508 100644 --- a/chrome/browser/autofill/phone_number_i18n.cc +++ b/chrome/browser/autofill/phone_number_i18n.cc @@ -315,7 +315,6 @@ string16 PhoneObject::GetWholeNumber() const { i18n::phonenumbers::PhoneNumberUtil* phone_util = i18n::phonenumbers::PhoneNumberUtil::GetInstance(); phone_util->Format(*i18n_number_, format, &formatted_number); - i18n::phonenumbers::PhoneNumberUtil::NormalizeDigitsOnly(&formatted_number); whole_number_ = UTF8ToUTF16(formatted_number); } return whole_number_; -- cgit v1.1