From 9adb9693e8a90bb63be325dbb5d3391f47f839ba Mon Sep 17 00:00:00 2001 From: "mpcomplete@chromium.org" <mpcomplete@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Fri, 29 Oct 2010 23:14:02 +0000 Subject: Part 3 of immutable Extension refactor. Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/automation/automation_resource_tracker.cc | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) (limited to 'chrome/browser/automation/automation_resource_tracker.cc') diff --git a/chrome/browser/automation/automation_resource_tracker.cc b/chrome/browser/automation/automation_resource_tracker.cc index c233b41..a82265d 100644 --- a/chrome/browser/automation/automation_resource_tracker.cc +++ b/chrome/browser/automation/automation_resource_tracker.cc @@ -15,7 +15,7 @@ AutomationResourceTrackerImpl::AutomationResourceTrackerImpl( AutomationResourceTrackerImpl::~AutomationResourceTrackerImpl() { } -int AutomationResourceTrackerImpl::AddImpl(void* resource) { +int AutomationResourceTrackerImpl::AddImpl(const void* resource) { if (ContainsResourceImpl(resource)) return resource_to_handle_[resource]; @@ -30,7 +30,7 @@ int AutomationResourceTrackerImpl::AddImpl(void* resource) { return handle; } -void AutomationResourceTrackerImpl::RemoveImpl(void* resource) { +void AutomationResourceTrackerImpl::RemoveImpl(const void* resource) { if (!ContainsResourceImpl(resource)) return; @@ -48,7 +48,7 @@ int AutomationResourceTrackerImpl::GenerateHandle() { return ++handle; } -bool AutomationResourceTrackerImpl::ContainsResourceImpl(void* resource) { +bool AutomationResourceTrackerImpl::ContainsResourceImpl(const void* resource) { return resource_to_handle_.find(resource) != resource_to_handle_.end(); } @@ -56,7 +56,7 @@ bool AutomationResourceTrackerImpl::ContainsHandleImpl(int handle) { return handle_to_resource_.find(handle) != handle_to_resource_.end(); } -void* AutomationResourceTrackerImpl::GetResourceImpl(int handle) { +const void* AutomationResourceTrackerImpl::GetResourceImpl(int handle) { HandleToResourceMap::const_iterator iter = handle_to_resource_.find(handle); if (iter == handle_to_resource_.end()) return NULL; @@ -64,7 +64,7 @@ void* AutomationResourceTrackerImpl::GetResourceImpl(int handle) { return iter->second; } -int AutomationResourceTrackerImpl::GetHandleImpl(void* resource) { +int AutomationResourceTrackerImpl::GetHandleImpl(const void* resource) { ResourceToHandleMap::const_iterator iter = resource_to_handle_.find(resource); if (iter == resource_to_handle_.end()) @@ -73,7 +73,8 @@ int AutomationResourceTrackerImpl::GetHandleImpl(void* resource) { return iter->second; } -void AutomationResourceTrackerImpl::HandleCloseNotification(void* resource) { +void AutomationResourceTrackerImpl::HandleCloseNotification( + const void* resource) { if (!ContainsResourceImpl(resource)) return; -- cgit v1.1