About Pages

From 2c2e8ca578ba1ce7f01d9a88f7ee859af11ebba6 Mon Sep 17 00:00:00 2001 From: "pkasting@chromium.org" Date: Thu, 10 Feb 2011 18:06:29 +0000 Subject: Revert 74451 - Add autocomplete provider for "about:" URLs. Original patch by simonmorris@chromium.org (see http://codereview.chromium.org/6246016/ ), r=me. BUG=6870 TEST=Typing "about:s" into the omnibox should result in a couple of "about:s..." URL entries in the dropdown even if you've never visited them. TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/6485004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74454 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/browser_about_handler.cc | 53 +++++++++++---------------------- 1 file changed, 18 insertions(+), 35 deletions(-) (limited to 'chrome/browser/browser_about_handler.cc') diff --git a/chrome/browser/browser_about_handler.cc b/chrome/browser/browser_about_handler.cc index eb08762..c4747d9 100644 --- a/chrome/browser/browser_about_handler.cc +++ b/chrome/browser/browser_about_handler.cc @@ -131,7 +131,6 @@ const char kOSCreditsPath[] = "os-credits"; // Add path here to be included in about:about const char *kAllAboutPaths[] = { - kAboutPath, kAppCacheInternalsPath, kBlobInternalsPath, kCachePath, @@ -260,13 +259,24 @@ std::string AboutAbout() { std::string html; html.append("About Pages\n"); html.append("

List of About pages

paths = AboutPaths(); - for (std::vector::const_iterator path = paths.begin(); - path != paths.end(); ++path) { - html.append("

about:"); - html.append(*path); + for (size_t i = 0; i < arraysize(kAllAboutPaths); i++) { + if (kAllAboutPaths[i] == kAppCacheInternalsPath || + kAllAboutPaths[i] == kBlobInternalsPath || + kAllAboutPaths[i] == kCachePath || +#if defined(OS_WIN) + kAllAboutPaths[i] == kConflictsPath || +#endif + kAllAboutPaths[i] == kFlagsPath || + kAllAboutPaths[i] == kGpuPath || + kAllAboutPaths[i] == kNetInternalsPath || + kAllAboutPaths[i] == kPluginsPath) { + html.append("

about:"); + html.append(kAllAboutPaths[i]); html.append("\n"); } const char *debug[] = { "crash", "kill", "hang", "shorthang", @@ -1069,30 +1079,3 @@ bool HandleNonNavigationAboutURL(const GURL& url) { return false; } - -std::vector AboutPaths() { - std::vector paths; - paths.reserve(arraysize(kAllAboutPaths)); - for (size_t i = 0; i < arraysize(kAllAboutPaths); i++) - paths.push_back(kAllAboutPaths[i]); - return paths; -} - -GURL AboutPathToURL(const std::string& path) { - InitializeAboutDataSource(); - if (LowerCaseEqualsASCII(path, kAppCacheInternalsPath) || - LowerCaseEqualsASCII(path, kBlobInternalsPath) || - LowerCaseEqualsASCII(path, kCachePath) || -#if defined(OS_WIN) - LowerCaseEqualsASCII(path, kConflictsPath) || -#endif - LowerCaseEqualsASCII(path, kFlagsPath) || - LowerCaseEqualsASCII(path, kGpuPath) || - LowerCaseEqualsASCII(path, kNetInternalsPath) || - LowerCaseEqualsASCII(path, kPluginsPath)) { - return GURL(std::string("chrome://") + std::string(path) + - std::string("/")); - } - return GURL(std::string("chrome://about/") + std::string(path) + - std::string("/")); -} -- cgit v1.1