beforeunload

From 548bc0f318c74e9a69973cb43c5403d03d114b52 Mon Sep 17 00:00:00 2001 From: "avi@chromium.org" Date: Wed, 9 Feb 2011 22:57:43 +0000 Subject: Remove wstring from RVH's run Javascript command. BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6458013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74362 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/browser_browsertest.cc | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) (limited to 'chrome/browser/browser_browsertest.cc') diff --git a/chrome/browser/browser_browsertest.cc b/chrome/browser/browser_browsertest.cc index 63a0a0b..35e933f 100644 --- a/chrome/browser/browser_browsertest.cc +++ b/chrome/browser/browser_browsertest.cc @@ -47,13 +47,13 @@ namespace { -const std::string BEFORE_UNLOAD_HTML = +const char* kBeforeUnloadHTML = "beforeunload" "" ""; -const std::wstring OPEN_NEW_BEFOREUNLOAD_PAGE = - L"w=window.open(); w.onbeforeunload=function(e){return 'foo'};"; +const char* kOpenNewBeforeUnloadPage = + "w=window.open(); w.onbeforeunload=function(e){return 'foo'};"; const FilePath::CharType* kTitle1File = FILE_PATH_LITERAL("title1.html"); const FilePath::CharType* kTitle2File = FILE_PATH_LITERAL("title2.html"); @@ -211,8 +211,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, JavascriptAlertActivatesTab) { EXPECT_EQ(0, browser()->selected_index()); TabContents* second_tab = browser()->GetTabContentsAt(1); ASSERT_TRUE(second_tab); - second_tab->render_view_host()->ExecuteJavascriptInWebFrame(L"", - L"alert('Activate!');"); + second_tab->render_view_host()->ExecuteJavascriptInWebFrame( + string16(), + ASCIIToUTF16("alert('Activate!');")); AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog(); alert->CloseModalDialog(); EXPECT_EQ(2, browser()->tab_count()); @@ -246,7 +247,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ThirtyFourTabs) { // Test for crbug.com/22004. Reloading a page with a before unload handler and // then canceling the dialog should not leave the throbber spinning. IN_PROC_BROWSER_TEST_F(BrowserTest, ReloadThenCancelBeforeUnload) { - GURL url("data:text/html," + BEFORE_UNLOAD_HTML); + GURL url(std::string("data:text/html,") + kBeforeUnloadHTML); ui_test_utils::NavigateToURL(browser(), url); // Navigate to another page, but click cancel in the dialog. Make sure that @@ -258,7 +259,8 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ReloadThenCancelBeforeUnload) { // Clear the beforeunload handler so the test can easily exit. browser()->GetSelectedTabContents()->render_view_host()-> - ExecuteJavascriptInWebFrame(L"", L"onbeforeunload=null;"); + ExecuteJavascriptInWebFrame(string16(), + ASCIIToUTF16("onbeforeunload=null;")); } // Crashy on mac. http://crbug.com/38522 @@ -274,13 +276,15 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, ReloadThenCancelBeforeUnload) { // two beforeunload dialogs shown. IN_PROC_BROWSER_TEST_F(BrowserTest, MAYBE_SingleBeforeUnloadAfterWindowClose) { browser()->GetSelectedTabContents()->render_view_host()-> - ExecuteJavascriptInWebFrame(L"", OPEN_NEW_BEFOREUNLOAD_PAGE); + ExecuteJavascriptInWebFrame(string16(), + ASCIIToUTF16(kOpenNewBeforeUnloadPage)); // Close the new window with JavaScript, which should show a single // beforeunload dialog. Then show another alert, to make it easy to verify // that a second beforeunload dialog isn't shown. browser()->GetTabContentsAt(0)->render_view_host()-> - ExecuteJavascriptInWebFrame(L"", L"w.close(); alert('bar');"); + ExecuteJavascriptInWebFrame(string16(), + ASCIIToUTF16("w.close(); alert('bar');")); AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog(); alert->native_dialog()->AcceptAppModalDialog(); -- cgit v1.1