From 93b86a850b7b1b3f46a7c4fc4521fefa8ca56e8d Mon Sep 17 00:00:00 2001 From: "phajdan.jr@chromium.org" Date: Thu, 8 Apr 2010 06:41:43 +0000 Subject: [GTTF] Clean up browser tests: - use more ui_test_utils functions to simplify the code - expose more consistent and powerful utilities in ui_test_utils - minor style improvements - move some tests from DISABLED to FLAKY so we don't lose coverage - remove redundant timeouts - check more return values TEST=browser_tests BUG=none Review URL: http://codereview.chromium.org/1571002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43931 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/browser_browsertest.cc | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'chrome/browser/browser_browsertest.cc') diff --git a/chrome/browser/browser_browsertest.cc b/chrome/browser/browser_browsertest.cc index 66922f5..ee51d90 100644 --- a/chrome/browser/browser_browsertest.cc +++ b/chrome/browser/browser_browsertest.cc @@ -364,7 +364,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, CommandCreateAppShortcut) { ui_test_utils::NavigateToURL(browser(), blank_url); EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS)); } -#endif +#endif // !defined(OS_MACOSX) // Test RenderView correctly send back favicon url for web page that redirects // to an anchor in javascript body.onload handler. @@ -452,8 +452,7 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, AppTabRemovedWhenExtensionUninstalled) { // The uninstall should have removed the tab. ASSERT_EQ(1, browser()->tab_count()); } - -#endif +#endif // !defined(OS_MACOSX) // Tests that the CLD (Compact Language Detection) works properly. IN_PROC_BROWSER_TEST_F(BrowserTest, PageLanguageDetection) { @@ -551,4 +550,4 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, RestorePinnedTabs) { EXPECT_TRUE(new_model->GetTabContentsAt(0)->app_extension() == app_extension); } -#endif +#endif // !defined(OS_CHROMEOS) -- cgit v1.1