From f8abf723d5fe8a85fade164dd030d4a13e0c7c29 Mon Sep 17 00:00:00 2001
From: "viettrungluu@chromium.org"
 <viettrungluu@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Wed, 7 Jul 2010 19:46:24 +0000
Subject: Start at cleaning up BrowserMain().

BUG=none (or is there?)
TEST=trybots and tests

Review URL: http://codereview.chromium.org/2234006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51763 0039d316-1c4b-4281-b951-d872f2087c98
---
 chrome/browser/browser_main.h | 92 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)

(limited to 'chrome/browser/browser_main.h')

diff --git a/chrome/browser/browser_main.h b/chrome/browser/browser_main.h
index d11d4d9..d23a7e5 100644
--- a/chrome/browser/browser_main.h
+++ b/chrome/browser/browser_main.h
@@ -5,9 +5,101 @@
 #ifndef CHROME_BROWSER_BROWSER_MAIN_H_
 #define CHROME_BROWSER_BROWSER_MAIN_H_
 
+#include "base/basictypes.h"
+#include "base/field_trial.h"
+#include "base/tracked_objects.h"
+
+class CommandLine;
 struct MainFunctionParams;
 class MetricsService;
 
+// BrowserMainParts:
+// This class contains different "stages" to be executed in |BrowserMain()|,
+// mostly initialization. This is made into a class rather than just functions
+// so each stage can create and maintain state. Each part is represented by a
+// single method (e.g., "EarlyInitialization()"), which does the following:
+//  - calls a method (e.g., "PreEarlyInitialization()") which individual
+//    platforms can override to provide platform-specific code which is to be
+//    executed before the common code;
+//  - calls various methods for things common to all platforms (for that given
+//    stage); and
+//  - calls a method (e.g., "PostEarlyInitialization()") for platform-specific
+//    code to be called after the common code.
+// As indicated above, platforms should override the default "Pre...()" and
+// "Post...()" methods when necessary; they need not call the superclass's
+// implementation (which is empty).
+//
+// Parts:
+//  - EarlyInitialization: things which should be done as soon as possible on
+//    program start (such as setting up signal handlers) and things to be done
+//    at some generic time before the start of the main message loop.
+//  - (more to come)
+class BrowserMainParts {
+ public:
+  // This static method is to be implemented by each platform and should
+  // instantiate the appropriate subclass.
+  static BrowserMainParts* CreateBrowserMainParts(
+      const MainFunctionParams& parameters);
+
+  // Parts to be called by |BrowserMain()|.
+  void EarlyInitialization();
+
+  // TODO(viettrungluu): This currently contains (POSIX) initialization done
+  // later than "EarlyInitialization()" but dependent on it. Once the
+  // refactoring includes that later stage, this should be put in some more
+  // generic platform-dependent method.
+  void TemporaryPosix_1() {}
+
+ protected:
+  explicit BrowserMainParts(const MainFunctionParams& parameters);
+
+  // Methods to be overridden to provide platform-specific code; these
+  // correspond to the "parts" above.
+  virtual void PreEarlyInitialization() {}
+  virtual void PostEarlyInitialization() {}
+
+  // Accessors for data members (below) ----------------------------------------
+  const MainFunctionParams& parameters() const {
+    return parameters_;
+  }
+  const CommandLine& parsed_command_line() const {
+    return parsed_command_line_;
+  }
+
+ private:
+  // Methods for |EarlyInitialization()| ---------------------------------------
+
+  // A/B test for the maximum number of persistent connections per host.
+  void ConnectionFieldTrial();
+
+  // A/B test for determining a value for unused socket timeout.
+  void SocketTimeoutFieldTrial();
+
+  // A/B test for spdy when --use-spdy not set.
+  void SpdyFieldTrial();
+
+  // Used to initialize NSPR where appropriate.
+  void InitializeSSL();
+
+  // Members initialized on construction ---------------------------------------
+
+  const MainFunctionParams& parameters_;
+  const CommandLine& parsed_command_line_;
+
+#if defined(TRACK_ALL_TASK_OBJECTS)
+  // Creating this object starts tracking the creation and deletion of Task
+  // instance. This MUST be done before main_message_loop, so that it is
+  // destroyed after the main_message_loop.
+  tracked_objects::AutoTracking tracking_objects_;
+#endif
+
+  // Statistical testing infrastructure for the entire browser.
+  FieldTrialList field_trial_;
+
+  DISALLOW_COPY_AND_ASSIGN(BrowserMainParts);
+};
+
+
 // Perform platform-specific work that needs to be done before the main
 // message loop is created, initialized, and entered.
 void WillInitializeMainMessageLoop(const MainFunctionParams& parameters);
-- 
cgit v1.1