From ce4b6a9dbb6ac14810294205185d385f066457fc Mon Sep 17 00:00:00 2001 From: "tony@chromium.org" Date: Thu, 10 Dec 2009 00:04:48 +0000 Subject: Make BrowserProcess::GetApplicationLocale thread safe and migrate callers of l10n_util::GetApplicationLocale to use this instead. In the browser process, it's wrong to call l10n_util::GetApplicationLocale with an empty string because then it won't consider the user pref value when resolving the locale. On Linux, it's also wrong to call l10n_util::GetApplicationLocale after startup because the call touches disk and on Linux, we assume that all of the program files can be deleted after startup (so updates in place can work). Review URL: http://codereview.chromium.org/476002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34206 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/browser_process.h | 1 + 1 file changed, 1 insertion(+) (limited to 'chrome/browser/browser_process.h') diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h index 3283318..d826321 100644 --- a/chrome/browser/browser_process.h +++ b/chrome/browser/browser_process.h @@ -125,6 +125,7 @@ class BrowserProcess { // Returns the locale used by the application. virtual const std::string& GetApplicationLocale() = 0; + virtual void set_application_locale(const std::string& locale) = 0; DownloadRequestManager* download_request_manager(); -- cgit v1.1