From fae20799882ef797ae9cb5a169c3a60680fa66c2 Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Wed, 28 Oct 2009 20:31:58 +0000 Subject: First of several patches to get rid of MessageLoop caching now that we have ChromeThread::PostTask. BUG=25354 Review URL: http://codereview.chromium.org/342020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30383 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/browser_process.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'chrome/browser/browser_process.h') diff --git a/chrome/browser/browser_process.h b/chrome/browser/browser_process.h index 6d96e3a..ff1361b 100644 --- a/chrome/browser/browser_process.h +++ b/chrome/browser/browser_process.h @@ -71,7 +71,11 @@ class BrowserProcess { // Returns the thread that we perform I/O coordination on (network requests, // communication with renderers, etc. - // NOTE: need to check the return value for NULL. + // NOTE: You should ONLY use this to pass to IPC or other objects which must + // need a MessageLoop*. If you just want to post a task, use + // ChromeThread::PostTask (or other variants) as they take care of checking + // that a thread is still alive, race conditions, lifetime differences etc. + // If you still must use this, need to check the return value for NULL. virtual base::Thread* io_thread() = 0; // Returns the thread that we perform random file operations on. For code -- cgit v1.1