From e4c8344a0d614851954f3001955bfcc01d70b838 Mon Sep 17 00:00:00 2001
From: "davemoore@chromium.org"
<davemoore@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Fri, 10 Sep 2010 23:43:24 +0000
Subject: Revert 59147 - Allow overriding of X error functions BUG=50006 (and
various other reports) TEST=Run chrome under nested window manager using
Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux)
use --enable-logging=stderr --log-level=0
kill xephyr
examine log. You should see
X IO Error detected
followed (not necessarily immediately) by
successfully saved /tmp/tx/Default/Preferences
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Local State
successfully saved /tmp/tx/Default/Preferences
along with no crash.
There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully.
Review URL: http://codereview.chromium.org/3175038
TBR=davemoore@chromium.org
Review URL: http://codereview.chromium.org/3332019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59175 0039d316-1c4b-4281-b951-d872f2087c98
---
chrome/browser/browser_process_impl.cc | 31 +++----------------------------
1 file changed, 3 insertions(+), 28 deletions(-)
(limited to 'chrome/browser/browser_process_impl.cc')
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 682c491..539bf57 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -11,7 +11,6 @@
#include "base/command_line.h"
#include "base/file_util.h"
#include "base/path_service.h"
-#include "base/task.h"
#include "base/thread.h"
#include "base/waitable_event.h"
#include "chrome/browser/appcache/chrome_appcache_service.h"
@@ -75,13 +74,6 @@
static const int kUpdateCheckIntervalHours = 6;
#endif
-#if defined(USE_X11)
-// How long to wait for the File thread to complete during EndSession, on
-// Linux. We have a timeout here because we're unable to run the UI messageloop
-// and there's some deadlock risk. Our only option is to exit anyway.
-static const int kEndSessionTimeoutSeconds = 10;
-#endif
-
BrowserProcessImpl::BrowserProcessImpl(const CommandLine& command_line)
: created_resource_dispatcher_host_(false),
created_metrics_service_(false),
@@ -223,16 +215,10 @@ BrowserProcessImpl::~BrowserProcessImpl() {
g_browser_process = NULL;
}
-#if defined(OS_WIN)
// Send a QuitTask to the given MessageLoop.
static void PostQuit(MessageLoop* message_loop) {
message_loop->PostTask(FROM_HERE, new MessageLoop::QuitTask());
}
-#elif defined(USE_X11)
-static void Signal(base::WaitableEvent* event) {
- event->Signal();
-}
-#endif
unsigned int BrowserProcessImpl::AddRefModule() {
DCHECK(CalledOnValidThread());
@@ -254,9 +240,9 @@ unsigned int BrowserProcessImpl::ReleaseModule() {
}
void BrowserProcessImpl::EndSession() {
-#if defined(OS_WIN) || defined(USE_X11)
+#if defined(OS_WIN)
// Notify we are going away.
- shutdown_event_->Signal();
+ ::SetEvent(shutdown_event_->handle());
#endif
// Mark all the profiles as clean.
@@ -278,20 +264,9 @@ void BrowserProcessImpl::EndSession() {
// We must write that the profile and metrics service shutdown cleanly,
// otherwise on startup we'll think we crashed. So we block until done and
// then proceed with normal shutdown.
-#if defined(USE_X11)
- // Can't run a local loop on linux. Instead create a waitable event.
- base::WaitableEvent done_writing(false, false);
- ChromeThread::PostTask(ChromeThread::FILE, FROM_HERE,
- NewRunnableFunction(Signal, &done_writing));
- done_writing.TimedWait(
- base::TimeDelta::FromSeconds(kEndSessionTimeoutSeconds));
-#elif defined(OS_WIN)
- ChromeThread::PostTask(ChromeThread::FILE, FROM_HERE,
+ g_browser_process->file_thread()->message_loop()->PostTask(FROM_HERE,
NewRunnableFunction(PostQuit, MessageLoop::current()));
MessageLoop::current()->Run();
-#else
- NOTIMPLEMENTED();
-#endif
}
ResourceDispatcherHost* BrowserProcessImpl::resource_dispatcher_host() {
--
cgit v1.1