From 8b034b702cd11acb174a1ece9ab837afbda86b77 Mon Sep 17 00:00:00 2001 From: "zelidrag@chromium.org" Date: Fri, 4 Jun 2010 18:02:05 +0000 Subject: Added final issue categories to feedback dialog for ChromeOS. BUG=chromium-os:3564 TEST=open the feedback/bug report dialog, check the new values in the dropdown Review URL: http://codereview.chromium.org/2553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48947 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/bug_report_util.cc | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) (limited to 'chrome/browser/bug_report_util.cc') diff --git a/chrome/browser/bug_report_util.cc b/chrome/browser/bug_report_util.cc index 5f6278e..844abfe 100644 --- a/chrome/browser/bug_report_util.cc +++ b/chrome/browser/bug_report_util.cc @@ -36,6 +36,7 @@ const char* const kPngMimeType = "image/png"; // Tags we use in product specific data const char* const kPageTitleTag = "PAGE TITLE"; +const char* const kProblemTypeIdTag = "PROBLEM TYPE ID"; const char* const kProblemTypeTag = "PROBLEM TYPE"; const char* const kChromeVersionTag = "CHROME VERSION"; const char* const kOsVersionTag = "OS VERSION"; @@ -130,6 +131,7 @@ void BugReportUtil::SendReport(Profile* profile, int png_width, #if defined(OS_CHROMEOS) int png_height, + const std::string& problem_type_text, const chromeos::LogDictionaryType* const sys_info) { #else int png_height) { @@ -154,9 +156,14 @@ void BugReportUtil::SendReport(Profile* profile, AddFeedbackData(&feedback_data, std::string(kPageTitleTag), page_title_text); - AddFeedbackData(&feedback_data, std::string(kProblemTypeTag), + AddFeedbackData(&feedback_data, std::string(kProblemTypeIdTag), StringPrintf("%d\r\n", problem_type)); +#if defined(OS_CHROMEOS) + AddFeedbackData(&feedback_data, std::string(kProblemTypeTag), + problem_type_text); +#endif + // Add the user e-mail to the feedback object common_data->set_user_email(user_email_text); @@ -190,9 +197,11 @@ void BugReportUtil::SendReport(Profile* profile, AddFeedbackData(&feedback_data, std::string(kOsVersionTag), os_version); #if defined(OS_CHROMEOS) - for (chromeos::LogDictionaryType::const_iterator i = sys_info->begin(); - i != sys_info->end(); ++i) - AddFeedbackData(&feedback_data, i->first, i->second); + if (sys_info) { + for (chromeos::LogDictionaryType::const_iterator i = sys_info->begin(); + i != sys_info->end(); ++i) + AddFeedbackData(&feedback_data, i->first, i->second); + } #endif // Include the page image if we have one. -- cgit v1.1