From 21ab5b9c9c64061b15d79a29b5ea337e4acc8953 Mon Sep 17 00:00:00 2001 From: "shess@chromium.org" Date: Fri, 11 Jun 2010 17:25:14 +0000 Subject: [Mac] Enable zombies for all on devchannel. Attempt to flush out more use-after-free cases in the wild. Right now messages to freed ObjC objects are binned by the object's address, with this change they should aggregate into a bigger bin. Additionally, the treadmill should slightly increase the number of cases caught. [Was reverted earlier due to Mac Perf(2). A fix to the zombie code should improve things.] BUG=35590,24987,45676 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48838 Review URL: http://codereview.chromium.org/2478004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49544 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/chrome_browser_application_mac.mm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'chrome/browser/chrome_browser_application_mac.mm') diff --git a/chrome/browser/chrome_browser_application_mac.mm b/chrome/browser/chrome_browser_application_mac.mm index 6e171fd..1a4c908 100644 --- a/chrome/browser/chrome_browser_application_mac.mm +++ b/chrome/browser/chrome_browser_application_mac.mm @@ -165,7 +165,9 @@ BOOL SwizzleNSExceptionInit() { + (void)initialize { // Turn all deallocated Objective-C objects into zombies, keeping // the most recent 10,000 of them on the treadmill. - DCHECK(ObjcEvilDoers::ZombieEnable(YES, 10000)); + // TODO(shess): Convert to a DCHECK() before the next beta channel. + // http://crbug.com/45676 + ObjcEvilDoers::ZombieEnable(YES, 10000); } - init { -- cgit v1.1