From e8b6ca09daa38e93c9f613c99a90e295ed3511ae Mon Sep 17 00:00:00 2001 From: "jam@chromium.org" Date: Wed, 10 Jul 2013 18:00:51 +0000 Subject: Small cleanup for ChromeBrowserMain: -add ChromeBrowserMainExtraPartsX11 to get rid of the x11 specific calls in ChromeBrowserMain that are right beside ChromeBrowserMainExtraParts calls -move win specific stuff out of ChromeBrowserMain and into ChromeBrowserMainWin -remove the static methods in chrome_browser_main.h in favor of private methods in chrome_browser_main.h -remove the unnecessary toolkit_extra_parts.h header, it doesn't help much since each method was named differently anyways R=thakis@chromium.org Review URL: https://codereview.chromium.org/18967002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210884 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/chrome_browser_main.h | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) (limited to 'chrome/browser/chrome_browser_main.h') diff --git a/chrome/browser/chrome_browser_main.h b/chrome/browser/chrome_browser_main.h index 067a616..0e092e4 100644 --- a/chrome/browser/chrome_browser_main.h +++ b/chrome/browser/chrome_browser_main.h @@ -101,6 +101,7 @@ class ChromeBrowserMainParts : public content::BrowserMainParts { } Profile* profile() { return profile_; } + bool do_first_run_tasks() const { return do_first_run_tasks_; } const PrefService* local_state() const { return local_state_; } @@ -119,6 +120,15 @@ class ChromeBrowserMainParts : public content::BrowserMainParts { // Returns true if the user opted in to sending metric reports. bool IsMetricsReportingEnabled(); + // Record time from process startup to present time in an UMA histogram. + // |is_first_run| - is the current launch part of a first run. + void RecordBrowserStartupTime(bool is_first_run); + + // Records a time value to an UMA histogram in the context of the + // PreReadExperiment field-trial. This also reports to the appropriate + // sub-histogram (_PreRead(Enabled|Disabled)). + void RecordPreReadExperimentTime(const char* name, base::TimeDelta time); + // Methods for Main Message Loop ------------------------------------------- int PreCreateThreadsImpl(); @@ -174,7 +184,6 @@ class ChromeBrowserMainParts : public content::BrowserMainParts { scoped_ptr process_singleton_; #endif scoped_ptr master_prefs_; - bool record_search_engine_; TranslateManager* translate_manager_; Profile* profile_; bool run_message_loop_; @@ -204,23 +213,4 @@ class ChromeBrowserMainParts : public content::BrowserMainParts { DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainParts); }; -// Records the conditions that can prevent Breakpad from generating and -// sending crash reports. The presence of a Breakpad handler (after -// attempting to initialize crash reporting) and the presence of a debugger -// are registered with the UMA metrics service. -void RecordBreakpadStatusUMA(MetricsService* metrics); - -// Displays a warning message if some minimum level of OS support is not -// present on the current platform. -void WarnAboutMinimumSystemRequirements(); - -// Record time from process startup to present time in an UMA histogram. -// |is_first_run| - is the current launch part of a first run. -void RecordBrowserStartupTime(bool is_first_run); - -// Records a time value to an UMA histogram in the context of the -// PreReadExperiment field-trial. This also reports to the appropriate -// sub-histogram (_PreRead(Enabled|Disabled)). -void RecordPreReadExperimentTime(const char* name, base::TimeDelta time); - #endif // CHROME_BROWSER_CHROME_BROWSER_MAIN_H_ -- cgit v1.1