From 1a98a93fc1977683c3789dedbef2806b3fcdf5b4 Mon Sep 17 00:00:00 2001 From: "ananta@chromium.org" Date: Tue, 17 Nov 2009 00:12:52 +0000 Subject: amit, please review everything, jam please review the changes to the tab_contents and the renderer_host sources. Remove the AutomationProfileImpl class which wraps the Chrome profile for an external tab container, which hosts ChromeFrame. This object was used to carry a custom URL request context which was used to intercept HTTP requests and cookie requests issued by external tabs. However as the life time of the automation profile class depended on the lifetime of the external tab container object this caused a number of crashes in objects which held on to the automation profile pointer retrieved from the associated tab contents. This does not happen in a regualar Chrome browser instance as the profile is deleted at the very end. We can associate the automation URL request context with the underlying tab_contents which would eventually percolate down to the resource message filter. Doing this would avoid the need for the AutomationProfile class. This CL achieves that. Bug=27695,27662 Review URL: http://codereview.chromium.org/385117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32127 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/chromeos/main_menu.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'chrome/browser/chromeos') diff --git a/chrome/browser/chromeos/main_menu.cc b/chrome/browser/chromeos/main_menu.cc index 5a8e2e1..e5a2bae 100644 --- a/chrome/browser/chromeos/main_menu.cc +++ b/chrome/browser/chromeos/main_menu.cc @@ -14,6 +14,7 @@ #include "base/string_util.h" #include "chrome/browser/browser_list.h" #include "chrome/browser/browser.h" +#include "chrome/browser/profile.h" #include "chrome/browser/renderer_host/render_view_host.h" #include "chrome/browser/renderer_host/render_view_host_factory.h" #include "chrome/browser/renderer_host/render_widget_host_view.h" @@ -151,7 +152,7 @@ MainMenu::MainMenu() rwhv_ = new RenderWidgetHostViewGtk(menu_rvh_); rwhv_->InitAsChild(); - menu_rvh_->CreateRenderView(); + menu_rvh_->CreateRenderView(browser_->profile()->GetRequestContext()); menu_popup->AddChild(rwhv_->GetNativeView()); gfx::Size rwhv_size = CalculateRWHVSize(popup_size); menu_popup->PositionChild(rwhv_->GetNativeView(), kRendererX, kRendererY, -- cgit v1.1