From feacf6810018543467b9befdfdc0d52dc9ae7d92 Mon Sep 17 00:00:00 2001 From: "akalin@chromium.org" Date: Thu, 3 Dec 2009 23:54:45 +0000 Subject: Created HtmlDialogTabContentsDelegate, which encapsulates the TabContentsDelegate behavior for HTML dialogs. Made all three implementations (gtk, win32, and cocoa) use it. This also makes HTML dialogs not tied to a Browser instance. Also, unlike the current behavior, any links followed from an HTML dialog box will be opened in a non-incognito browser, even if the HTML dialog was launched from an incognito browser. According to beng, this is okay. BUG=28609 TEST=unittests, manual testing on linux/windows/os x with sync setup wizard Review URL: http://codereview.chromium.org/441011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33752 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/cocoa/html_dialog_window_controller.h | 1 - 1 file changed, 1 deletion(-) (limited to 'chrome/browser/cocoa/html_dialog_window_controller.h') diff --git a/chrome/browser/cocoa/html_dialog_window_controller.h b/chrome/browser/cocoa/html_dialog_window_controller.h index 26b761d..c8e3884 100644 --- a/chrome/browser/cocoa/html_dialog_window_controller.h +++ b/chrome/browser/cocoa/html_dialog_window_controller.h @@ -22,7 +22,6 @@ class TabContents; // from a HTMLDialogUIDelegate object. @interface HtmlDialogWindowController : NSWindowController { @private - Profile* profile_; // weak. Always a non-incognito profile. // Order here is important, as tab_contents_ may send messages to // delegate_ when it gets destroyed. scoped_ptr delegate_; -- cgit v1.1