From 46ebf0640d32b313618fe443a34e959059b2c3f9 Mon Sep 17 00:00:00 2001
From: "ziadh@chromium.org"
 <ziadh@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Date: Sat, 24 Jul 2010 02:47:40 +0000
Subject: Add undeclared virtual destructors.

Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks.

r=jar

Review URL: http://codereview.chromium.org/2856051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53570 0039d316-1c4b-4281-b951-d872f2087c98
---
 .../cocoa/location_bar/autocomplete_text_field.h    |  3 +++
 chrome/browser/cocoa/table_row_nsimage_cache.h      | 21 ++++++++++++---------
 2 files changed, 15 insertions(+), 9 deletions(-)

(limited to 'chrome/browser/cocoa')

diff --git a/chrome/browser/cocoa/location_bar/autocomplete_text_field.h b/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
index 0340874..aad52a6 100644
--- a/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
+++ b/chrome/browser/cocoa/location_bar/autocomplete_text_field.h
@@ -89,6 +89,9 @@ class AutocompleteTextFieldObserver {
 
   // Called whenever the autocomplete text field is losing focus.
   virtual void OnKillFocus() = 0;
+
+ protected:
+  virtual ~AutocompleteTextFieldObserver() {}
 };
 
 @interface AutocompleteTextField : StyledTextField<NSTextViewDelegate,
diff --git a/chrome/browser/cocoa/table_row_nsimage_cache.h b/chrome/browser/cocoa/table_row_nsimage_cache.h
index 6409123..a8c0052 100644
--- a/chrome/browser/cocoa/table_row_nsimage_cache.h
+++ b/chrome/browser/cocoa/table_row_nsimage_cache.h
@@ -15,15 +15,18 @@
 // caches the results.
 class TableRowNSImageCache {
  public:
-   // Interface this cache expects for its table model.
-   class Table {
-    public:
-     // Returns the number of rows in the table.
-     virtual int RowCount() const = 0;
-
-     // Returns the icon of the |row|th row.
-     virtual SkBitmap GetIcon(int row) const = 0;
-   };
+  // Interface this cache expects for its table model.
+  class Table {
+   public:
+    // Returns the number of rows in the table.
+    virtual int RowCount() const = 0;
+
+    // Returns the icon of the |row|th row.
+    virtual SkBitmap GetIcon(int row) const = 0;
+
+   protected:
+    virtual ~Table() {}
+  };
 
   // |model| must outlive the cache.
   explicit TableRowNSImageCache(Table* model);
-- 
cgit v1.1