From 82f7248c0e48ee71c4b78f9d305caefc7fa9bab2 Mon Sep 17 00:00:00 2001 From: oshima Date: Fri, 24 Oct 2014 07:14:32 -0700 Subject: Componentize app_modal_dialog Notable changes (other than just moving code aruond) * kJavaScriptMessageExpectedDelay constant has been moved from chrome_constants to javascript_dialog_manager.cc because that's the only place used. * NOTIFICATION_APP_MODAL_DIALOG_SHOWN notification has been removed and replaced by test only waiter class. (as this notification was used only in tests) * Moved and creates string resource for app_modal_dialog. Next step: move dialog implementations to compoents/app_modal_dialogs (javascript_dialog_manager/ javascript_app_modal_dialogs_views/, javascript_app_modal_dialogs_cocoa ....) BUG=422092 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/648833004 Cr-Commit-Position: refs/heads/master@{#301095} --- chrome/browser/extensions/alert_apitest.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'chrome/browser/extensions/alert_apitest.cc') diff --git a/chrome/browser/extensions/alert_apitest.cc b/chrome/browser/extensions/alert_apitest.cc index 893a9b4..dbd7c55 100644 --- a/chrome/browser/extensions/alert_apitest.cc +++ b/chrome/browser/extensions/alert_apitest.cc @@ -5,9 +5,9 @@ #include "base/strings/utf_string_conversions.h" #include "chrome/browser/extensions/extension_apitest.h" #include "chrome/browser/profiles/profile.h" -#include "chrome/browser/ui/app_modal_dialogs/app_modal_dialog.h" #include "chrome/browser/ui/browser.h" #include "chrome/test/base/ui_test_utils.h" +#include "components/app_modal_dialogs/app_modal_dialog.h" #include "content/public/browser/render_frame_host.h" #include "extensions/browser/extension_host.h" #include "extensions/browser/extension_system.h" -- cgit v1.1